GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/apollolake/uart.c: Do not NOOP .set_resources() and friends 

When SOC_UART_DEBUG was not set, the boot would hang somwhere in
ramstage, as evidenced by POST codes reported from the EC. This was
traced to the .set_resources and .enable_resources members of the UART
PCI driver being set to NOOP.
Although the exact mechanism of failure is not known, this change
eliminates the hang.

Change-Id: Ic2f3d56a964ec890ebfa1e1a7770f1ae2eb22281
Signed-off-by: Alexandru Gagniuc <alexandrux.gagniuc@intel.com>
Reviewed-on: https://review.coreboot.org/14771
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Alexandru Gagniuc 2016-05-10 14:46:07 -07:00 committed by Aaron Durbin
parent 74d06f2554
commit e22f536bf8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/soc/intel/apollolake/uart.c
View File

@ -42,8 +42,8 @@ static void aplk_uart_read_resources(struct device *dev)
static struct device_operations uart_ops = { static struct device_operations uart_ops = {
.read_resources = aplk_uart_read_resources, .read_resources = aplk_uart_read_resources,
.set_resources = DEVICE_NOOP, .set_resources = pci_dev_set_resources,
.enable_resources = DEVICE_NOOP, .enable_resources = pci_dev_enable_resources,
.init = pci_dev_init, .init = pci_dev_init,
.enable = DEVICE_NOOP .enable = DEVICE_NOOP
}; };