GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/block/include/psp_efs: use unsigned type for bitfield 

For 1 bit long bit fields an unsigned type should be used. In this case
uint32_t is used instead of a generic unsigned int for both consistency
reasons with the rest of the file and to clarify that the bits will be
packed into a 32 bit memory location.

TEST=Resulting image of a timeless build for google/guybrush results in
identical binary.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ic630d1709174d90336746bc37da504437c12643c
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58224
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
This commit is contained in:
Felix Held 2021-10-01 20:11:45 +02:00 committed by Felix Held
parent d2fadda52a
commit e240f8761f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/soc/amd/common/block/include/amdblocks/psp_efs.h
View File

@ -26,8 +26,8 @@
struct second_gen_efs { /* todo: expand for Server products */ struct second_gen_efs { /* todo: expand for Server products */
int gen:1; /* Client products only use bit 0 */ uint32_t gen:1; /* Client products only use bit 0 */
int reserved:31; uint32_t reserved:31;
} __attribute__((packed)); } __attribute__((packed));
/* Copied from coreboot/util/amdfwtool.h */ /* Copied from coreboot/util/amdfwtool.h */