From e24f7d37cef5acb71c070f934a74286efb6ee32e Mon Sep 17 00:00:00 2001 From: Timothy Pearson Date: Thu, 19 Mar 2015 00:03:59 -0500 Subject: [PATCH] cpu/amd/model_10xxx: Fix UMA memory sizes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix up commit 4916880 (cpu/amd/model_10xxx: Move GFXUMA size calculation to separate function) unintentionally changing behavior when converting the switch statement to an if-else statement. Change-Id: I8d126aaec1b324face6407a2b451e603e61db0e5 Signed-off-by: Timothy Pearson Reviewed-on: http://review.coreboot.org/8748 Tested-by: build bot (Jenkins) Reviewed-by: Kyösti Mälkki Reviewed-by: Paul Menzel --- src/cpu/amd/model_10xxx/ram_calc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/cpu/amd/model_10xxx/ram_calc.c b/src/cpu/amd/model_10xxx/ram_calc.c index 98b80e96b9..c37c0ce41d 100644 --- a/src/cpu/amd/model_10xxx/ram_calc.c +++ b/src/cpu/amd/model_10xxx/ram_calc.c @@ -29,13 +29,13 @@ uint64_t get_uma_memory_size(uint64_t topmem) uint64_t uma_size = 0; if (IS_ENABLED(CONFIG_GFXUMA)) { /* refer to UMA Size Consideration in 780 BDG. */ - if (topmem > 0x40000000) /* 1GB and above system memory */ + if (topmem >= 0x40000000) /* 1GB and above system memory */ uma_size = 0x10000000; /* 256M recommended UMA */ - else if (topmem > 0x20000000) /* 512M - 1023M system memory */ + else if (topmem >= 0x20000000) /* 512M - 1023M system memory */ uma_size = 0x8000000; /* 128M recommended UMA */ - else if (topmem > 0x10000000) /* 256M - 511M system memory */ + else if (topmem >= 0x10000000) /* 256M - 511M system memory */ uma_size = 0x4000000; /* 64M recommended UMA */ }