GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/zork: Use SSDT generator for Chrome EC audio codec device 

This change drops the inclusion of codec.asl in DSDT for `GOOG0013`
device and instead uses the newly added Chrome EC audio codec driver
for filling in the device node in SSDT.

TEST=Verified that following node gets generated:
Scope (\_SB.PCI0.LPCB.EC0.CREC)
{
	Device (ECA0)
	{
		Name (_HID, "GOOG0013")  // _HID: Hardware ID
		Name (_UID, One)  // _UID: Unique ID
		Name (_DDN, "Cros EC audio codec")  // _DDN: DOS Device Name
		Method (_STA, 0, NotSerialized)  // _STA: Status
		{
			Return (0x0F)
		}
	}
}

Change-Id: I3e626ce01a3735ac2c966c0e95310be4c828b241
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43042
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Furquan Shaikh 2020-07-02 16:03:06 -07:00
parent 31b816b42f
commit e284bff9cf
10 changed files with 5 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/google/zork/Kconfig
View File

@ -19,6 +19,7 @@ config BOARD_SPECIFIC_OPTIONS
select DRIVERS_I2C_GENERIC
select DRIVERS_I2C_HID
select EC_GOOGLE_CHROMEEC
select EC_GOOGLE_CHROMEEC_AUDIO_CODEC
select EC_GOOGLE_CHROMEEC_BOARDID
select EC_GOOGLE_CHROMEEC_ESPI
select EC_GOOGLE_CHROMEEC_I2C_TUNNEL

2
src/mainboard/google/zork/dsdt.asl
View File

@ -60,8 +60,6 @@ DefinitionBlock (
#include <ec/google/chromeec/acpi/superio.asl>
/* ACPI code for EC functions */
#include <ec/google/chromeec/acpi/ec.asl>
/* ACPI code for EC I2C Audio Tunnel */
#include <variant/acpi/audio.asl>
}
}
/* End of ASL file */

4
src/mainboard/google/zork/variants/baseboard/devicetree.cb
View File

@ -163,6 +163,10 @@ chip soc/amd/picasso
register "remote_bus" = "9"
device generic 1.0 on end
end
chip ec/google/chromeec/audio_codec
register "uid" = "1"
device generic 0 on end
end
end
end
end

5
src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/audio.asl
View File

@ -1,5 +0,0 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */
Scope (EC0.CREC) {
#include <ec/google/chromeec/acpi/codec.asl>
}

3
src/mainboard/google/zork/variants/berknip/include/variant/acpi/audio.asl
View File

@ -1,3 +0,0 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <baseboard/acpi/audio.asl>

3
src/mainboard/google/zork/variants/dalboz/include/variant/acpi/audio.asl
View File

@ -1,3 +0,0 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <baseboard/acpi/audio.asl>

3
src/mainboard/google/zork/variants/ezkinil/include/variant/acpi/audio.asl
View File

@ -1,3 +0,0 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <baseboard/acpi/audio.asl>

3
src/mainboard/google/zork/variants/morphius/include/variant/acpi/audio.asl
View File

@ -1,3 +0,0 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <baseboard/acpi/audio.asl>

3
src/mainboard/google/zork/variants/trembyle/include/variant/acpi/audio.asl
View File

@ -1,3 +0,0 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <baseboard/acpi/audio.asl>

3
src/mainboard/google/zork/variants/vilboz/include/variant/acpi/audio.asl
View File

@ -1,3 +0,0 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <baseboard/acpi/audio.asl>