GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libpayload: fix OHCI IN commands 

Due to operator precedence incomming USB commands were missing some
flags.

Change-Id: I87ef51590c9db7a6cbc7304e1ccac29895f8a51e
Signed-off-by: Mathias Krause <mathias.krause@secunet.com>
Reviewed-on: http://review.coreboot.org/1084
Reviewed-by: Mathias Krause <minipli@googlemail.com>
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
This commit is contained in:
Mathias Krause 2012-05-29 14:28:26 +02:00 committed by Patrick Georgi
parent 7b7b5666f0
commit e28a61550c
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
payloads/libpayload/drivers/usb/ohci.c
View File

@ -279,7 +279,7 @@ ohci_control (usbdev_t *dev, direction_t dir, int drlen, void *devreq, int dalen
while (pages > 0) { while (pages > 0) {
cur++; cur++;
cur->config = (dir==IN)?TD_DIRECTION_IN:TD_DIRECTION_OUT | cur->config = (dir == IN ? TD_DIRECTION_IN : TD_DIRECTION_OUT) |
TD_DELAY_INTERRUPT_NODELAY | TD_DELAY_INTERRUPT_NODELAY |
TD_TOGGLE_FROM_ED | TD_TOGGLE_FROM_ED |
TD_CC_NOACCESS; TD_CC_NOACCESS;
@ -306,7 +306,7 @@ ohci_control (usbdev_t *dev, direction_t dir, int drlen, void *devreq, int dalen
} }
cur++; cur++;
cur->config = (dir==IN)?TD_DIRECTION_OUT:TD_DIRECTION_IN | cur->config = (dir == IN ? TD_DIRECTION_OUT : TD_DIRECTION_IN) |
TD_DELAY_INTERRUPT_NODELAY | TD_DELAY_INTERRUPT_NODELAY |
TD_TOGGLE_FROM_TD | TD_TOGGLE_FROM_TD |
TD_TOGGLE_DATA1 | TD_TOGGLE_DATA1 |
@ -373,7 +373,7 @@ ohci_bulk (endpoint_t *ep, int dalen, u8 *data, int finalize)
} }
for (cur = tds; cur->next_td != 0; cur++) { for (cur = tds; cur->next_td != 0; cur++) {
cur->config = (ep->direction==IN)?TD_DIRECTION_IN:TD_DIRECTION_OUT | cur->config = (ep->direction == IN ? TD_DIRECTION_IN : TD_DIRECTION_OUT) |
TD_DELAY_INTERRUPT_NODELAY | TD_DELAY_INTERRUPT_NODELAY |
TD_TOGGLE_FROM_ED | TD_TOGGLE_FROM_ED |
TD_CC_NOACCESS; TD_CC_NOACCESS;