From e28c71802d338ecc831776ed3d963a3cfc8ad302 Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Wed, 22 Jun 2022 17:49:31 -0600 Subject: [PATCH] Makefile: Update error if building real-all when NOCOMPILE is set The real-all target here had never been updated since the original NOCOMPILE, which only depended on DOTCONFIG. Since the reasons that the NOCOMPILE flag can be set is much larger now, the error given no longer matches the possible issues. Give the reason for the failure (nocompile is set), some debug info, and ask the user to file a bug. We shouldn't really ever run across this, but I just saw it when I was working on the NOCOMPILE code. Signed-off-by: Martin Roth Change-Id: I5b4be3349fb4cf2d3a8a2a7c183b7a205b9e8733 Reviewed-on: https://review.coreboot.org/c/coreboot/+/65319 Tested-by: build bot (Jenkins) Reviewed-by: Elyes Haouas --- Makefile | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index ae4e3987fe..f9bb258de9 100644 --- a/Makefile +++ b/Makefile @@ -136,9 +136,11 @@ include $(TOPLEVEL)/util/testing/Makefile.inc -include $(TOPLEVEL)/site-local/Makefile.inc include $(TOPLEVEL)/tests/Makefile.inc real-all: - @echo "Error: Expected config file ($(DOTCONFIG)) not present." >&2 - @echo "Please specify a config file or run 'make menuconfig' to" >&2 - @echo "generate a new config file." >&2 + @echo "Error: Trying to build, but NOCOMPILE is set." >&2 + @echo " Please file a bug with the following information:" + @echo "- MAKECMDGOALS: $(MAKECMDGOALS)" >&2 + @echo "- HAVE_DOTCONFIG: $(HAVE_DOTCONFIG)" >&2 + @echo "- HAVE_KCONFIG_MAKEFILE_REAL: $(HAVE_KCONFIG_MAKEFILE_REAL)" >&2 @exit 1 else