GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/amd/mct_ddr3: Use standard C function calls in mct_ResetDataStruct_D() 

Replace open coded memset() functions with calls to the library function.
The new code also explicitly backs up and restores the data structures
that are preserved across calls to mct_ResetDataStruct_D(), and no longer
relies on structure member order to function correctly.

Change-Id: I6dd6377deda0087cd1b65f7555588978657d6516
Signed-off-by: Timothy Pearson <tpearson@raptorengineeringinc.com>
Reviewed-on: https://review.coreboot.org/14165
Tested-by: build bot (Jenkins)
Tested-by: Raptor Engineering Automated Test Stand <noreply@raptorengineeringinc.com>
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Timothy Pearson 2016-03-24 19:31:02 -05:00
parent ec38c3d956
commit e2e0057ee7
1 changed files with 8 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
View File

@ -1,7 +1,7 @@
/* /*
* This file is part of the coreboot project. * This file is part of the coreboot project.
* *
* Copyright (C) 2015 Timothy Pearson <tpearson@raptorengineeringinc.com>, Raptor Engineering * Copyright (C) 2015-2016 Raptor Engineering, LLC
* Copyright (C) 2010 Advanced Micro Devices, Inc. * Copyright (C) 2010 Advanced Micro Devices, Inc.
* *
* This program is free software; you can redistribute it and/or modify * This program is free software; you can redistribute it and/or modify
@ -7407,38 +7407,25 @@ static u8 CheckNBCOFEarlyArbEn(struct MCTStatStruc *pMCTstat,
static void mct_ResetDataStruct_D(struct MCTStatStruc *pMCTstat, static void mct_ResetDataStruct_D(struct MCTStatStruc *pMCTstat,
struct DCTStatStruc *pDCTstatA) struct DCTStatStruc *pDCTstatA)
{ {
u8 Node; uint8_t Node;
u32 i;
struct DCTStatStruc *pDCTstat; struct DCTStatStruc *pDCTstat;
u32 start, stop; uint16_t host_serv1, host_serv2;
u8 *p; uint8_t CH_D_B_TxDqs_bkp[2][4][9];
u16 host_serv1, host_serv2;
/* Initialize Data structures by clearing all entries to 0 */ /* Initialize Data structures by clearing all entries to 0 */
p = (u8 *) pMCTstat; memset(pMCTstat, 0, sizeof(struct MCTStatStruc));
for (i = 0; i < sizeof(struct MCTStatStruc); i++) {
p[i] = 0;
}
for (Node = 0; Node < 8; Node++) { for (Node = 0; Node < 8; Node++) {
pDCTstat = pDCTstatA + Node; pDCTstat = pDCTstatA + Node;
host_serv1 = pDCTstat->HostBiosSrvc1; host_serv1 = pDCTstat->HostBiosSrvc1;
host_serv2 = pDCTstat->HostBiosSrvc2; host_serv2 = pDCTstat->HostBiosSrvc2;
memcpy(CH_D_B_TxDqs_bkp, pDCTstat->CH_D_B_TxDqs, sizeof(CH_D_B_TxDqs_bkp));
p = (u8 *) pDCTstat; memset(pDCTstat, 0, sizeof(struct DCTStatStruc));
start = 0;
stop = ((u32) &((struct DCTStatStruc *)0)->CH_D_DIR_B_DQS);
for (i = start; i < stop ; i++) {
p[i] = 0;
}
start = ((u32) &((struct DCTStatStruc *)0)->CH_D_BC_RCVRDLY[2][4]);
stop = sizeof(struct DCTStatStruc);
for (i = start; i < stop; i++) {
p[i] = 0;
}
pDCTstat->HostBiosSrvc1 = host_serv1; pDCTstat->HostBiosSrvc1 = host_serv1;
pDCTstat->HostBiosSrvc2 = host_serv2; pDCTstat->HostBiosSrvc2 = host_serv2;
memcpy(pDCTstat->CH_D_B_TxDqs, CH_D_B_TxDqs_bkp, sizeof(pDCTstat->CH_D_B_TxDqs));
} }
} }