GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

intel raminit: rewrite timB high adjust calculation 

Found while doing code review.

Simplify the code by using a loop for positive and negative phase
adjustments.

Change-Id: I0980443d0d2815bccef969709fddecc07d61a788
Signed-off-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-on: http://review.coreboot.org/10890
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-by: Nicolas Reinecke <nr@das-labor.org>
This commit is contained in:
Patrick Rudolph 2015-07-12 17:01:42 +02:00 committed by Patrick Georgi
parent 0620b1e8a3
commit e324cc91e0
1 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/northbridge/intel/sandybridge/raminit_native.c
View File

@ -2288,18 +2288,17 @@ static int get_timB_high_adjust(u64 val)
if (val == 0xffffffffffffffffLL)
return 0;
if (val >= 0xfffffffffffff000LL)
return 3;
if (val >= 0xfffffffffff00000LL)
return -1;
if (val >= 0xfffffff000000000LL)
return -2;
if (val >= 0xfff0000000000000LL)
return -3;
for (i = 0; i < 8; i++)
if (val >> (8 * (7 - i) + 4))
return i;
if (val >= 0xf000000000000000LL) {
/* needs negative adjustment */
for (i = 0; i < 8; i++)
if (val << (8 * (7 - i) + 4))
return -i;
} else {
/* needs positive adjustment */
for (i = 0; i < 8; i++)
if (val >> (8 * (7 - i) + 4))
return i;
}
return 8;
}