GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/amd/pi/00730F01/northbridge: use get_top_of_mem_[below,above]_4gb 

Use get_top_of_mem_below_4gb and get_top_of_mem_above_4g instead of
open-coding the functionality.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I6332b051acf8d00ba6528360b18ea0d3c4dc30fd
Reviewed-on: https://review.coreboot.org/c/coreboot/+/74611
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martin.roth@amd.corp-partner.google.com>
This commit is contained in:
Felix Held 2023-04-20 13:06:08 +02:00
parent fb532c711e
commit e345378354
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/northbridge/amd/pi/00730F01/northbridge.c
View File

@ -538,13 +538,11 @@ static unsigned long acpi_fill_ivrs(acpi_ivrs_t *ivrs, unsigned long current)
static void northbridge_fill_ssdt_generator(const struct device *device) static void northbridge_fill_ssdt_generator(const struct device *device)
{ {
msr_t msr;
char pscope[] = "\\_SB.PCI0"; char pscope[] = "\\_SB.PCI0";
acpigen_write_scope(pscope); acpigen_write_scope(pscope);
msr = rdmsr(TOP_MEM); acpigen_write_name_dword("TOM1", get_top_of_mem_below_4gb());
acpigen_write_name_dword("TOM1", msr.lo);
msr = rdmsr(TOP_MEM2);
/* /*
* Since XP only implements parts of ACPI 2.0, we can't use a qword * Since XP only implements parts of ACPI 2.0, we can't use a qword
* here. * here.
@ -553,7 +551,7 @@ static void northbridge_fill_ssdt_generator(const struct device *device)
* Shift value right by 20 bit to make it fit into 32bit, * Shift value right by 20 bit to make it fit into 32bit,
* giving us 1MB granularity and a limit of almost 4Exabyte of memory. * giving us 1MB granularity and a limit of almost 4Exabyte of memory.
*/ */
acpigen_write_name_dword("TOM2", (msr.hi << 12) | msr.lo >> 20); acpigen_write_name_dword("TOM2", get_top_of_mem_above_4g() >> 20);
acpigen_pop_len(); acpigen_pop_len();
} }