GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/baytrail: fix scope for I2C ACPI devices 

For an unknown reason, the I2C ACPI devices were placed
under \SB intead of \SB.PCI0, as with all other non-Atom
based Intel platforms.  While Linux is tolerant of this,
Windows is not.  Correct by moving I2C ACPI devices where
they belong.

Also, adjust I2C devices at board level for google/rambi
as to not break compilation.

Change-Id: I4ef978214aa36078dc04ee1c73b3e2b4bb22f692
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/20056
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
Matt DeVillier 2017-01-09 01:35:48 -06:00 committed by Martin Roth
parent 4b18a922f0
commit e34a7705e6
7 changed files with 16 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/mainboard/google/rambi/acpi/mainboard.asl
View File

@ -81,7 +81,7 @@ Scope (\_SB)
#endif
}
Scope (\_SB.I2C2)
Scope (\_SB.PCI0.I2C2)
{
Device (CODC)
{
@ -102,7 +102,7 @@ Scope (\_SB.I2C2)
ControllerInitiated, // SlaveMode
400000, // ConnectionSpeed
AddressingMode7Bit, // AddressingMode
"\\_SB.I2C2", // ResourceSource
"\\_SB.PCI0.I2C2", // ResourceSource
)
Interrupt (ResourceConsumer, Level, ActiveLow)
{
@ -121,7 +121,7 @@ Scope (\_SB.I2C2)
}
}
Scope (\_SB.LPEA)
Scope (\_SB.PCI0.LPEA)
{
Name (GBUF, ResourceTemplate ()
{

4
src/mainboard/google/rambi/acpi/touchscreen_atmel.asl
View File

@ -14,7 +14,7 @@
#include <variant/onboard.h>
Scope (\_SB.I2C6)
Scope (\_SB.PCI0.I2C6)
{
Device (ATSA)
{
@ -31,7 +31,7 @@ Scope (\_SB.I2C6)
ControllerInitiated, // SlaveMode
400000, // ConnectionSpeed
AddressingMode7Bit, // AddressingMode
"\\_SB.I2C6", // ResourceSource
"\\_SB.PCI0.I2C6", // ResourceSource
)
Interrupt (ResourceConsumer, Level, ActiveLow)
{

4
src/mainboard/google/rambi/acpi/touchscreen_elan.asl
View File

@ -14,7 +14,7 @@
#include <variant/onboard.h>
Scope (\_SB.I2C6)
Scope (\_SB.PCI0.I2C6)
{
Device (ETSA)
{
@ -30,7 +30,7 @@ Scope (\_SB.I2C6)
ControllerInitiated, // SlaveMode
400000, // ConnectionSpeed
AddressingMode7Bit, // AddressingMode
"\\_SB.I2C6", // ResourceSource
"\\_SB.PCI0.I2C6", // ResourceSource
)
Interrupt (ResourceConsumer, Level, ActiveLow)
{

4
src/mainboard/google/rambi/acpi/touchscreen_wdt.asl
View File

@ -14,7 +14,7 @@
#include <variant/onboard.h>
Scope (\_SB.I2C6)
Scope (\_SB.PCI0.I2C6)
{
Device (WTSA)
{
@ -30,7 +30,7 @@ Scope (\_SB.I2C6)
ControllerInitiated, // SlaveMode
400000, // ConnectionSpeed
AddressingMode7Bit, // AddressingMode
"\\_SB.I2C6", // ResourceSource
"\\_SB.PCI0.I2C6", // ResourceSource
)
Interrupt (ResourceConsumer, Level, ActiveLow)
{

4
src/mainboard/google/rambi/acpi/trackpad_atmel.asl
View File

@ -14,7 +14,7 @@
#include <variant/onboard.h>
Scope (\_SB.I2C1)
Scope (\_SB.PCI0.I2C1)
{
Device (ATPA)
{
@ -30,7 +30,7 @@ Scope (\_SB.I2C1)
ControllerInitiated, // SlaveMode
400000, // ConnectionSpeed
AddressingMode7Bit, // AddressingMode
"\\_SB.I2C1", // ResourceSource
"\\_SB.PCI0.I2C1", // ResourceSource
)
Interrupt (ResourceConsumer, Level, ActiveLow)
{

4
src/mainboard/google/rambi/acpi/trackpad_elan.asl
View File

@ -14,7 +14,7 @@
#include <variant/onboard.h>
Scope (\_SB.I2C1)
Scope (\_SB.PCI0.I2C1)
{
Device (ETPA)
{
@ -30,7 +30,7 @@ Scope (\_SB.I2C1)
ControllerInitiated, // SlaveMode
400000, // ConnectionSpeed
AddressingMode7Bit, // AddressingMode
"\\_SB.I2C1", // ResourceSource
"\\_SB.PCI0.I2C1", // ResourceSource
)
Interrupt (ResourceConsumer, Level, ActiveLow)
{

3
src/soc/intel/baytrail/acpi/southcluster.asl
View File

@ -258,7 +258,10 @@ Scope (\_SB)
{
// GPIO Devices
#include "gpio.asl"
}
Scope (\_SB.PCI0)
{
// LPSS Devices
#include "lpss.asl"