GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Apparently I'm not the only one who forgets which way the outb and 

outl arguments go.

Signed-off-by: Ed Swierk <eswierk@aristanetworks.com>
Acked-by: Peter Stuge <peter@stuge.se>


git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4422 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
This commit is contained in:
Ed Swierk 2009-07-10 15:05:35 +00:00 committed by Ed Swierk
parent 7d4fd2c108
commit e42e142d9f
5 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/cpu/amd/sc520/raminit.c
View File

@ -183,16 +183,16 @@ void setupsc520(void)
/* Stepan says: This needs to go to the msm586seg code */ /* Stepan says: This needs to go to the msm586seg code */
/* "enumerate" the PCI. Mainly set the interrupt bits on the PCnetFast. */ /* "enumerate" the PCI. Mainly set the interrupt bits on the PCnetFast. */
outl(0xcf8, 0x08000683c); outl(0x08000683c, 0xcf8);
outl(0xcfc, 0xc); /* set the interrupt line */ outl(0xc, 0xcfc); /* set the interrupt line */
/* Set the SC520 PCI host bridge to target mode to /* Set the SC520 PCI host bridge to target mode to
* allow external bus mastering events * allow external bus mastering events
*/ */
/* index the status command register on device 0*/ /* index the status command register on device 0*/
outl(0x0cf8,0x080000004); outl(0x080000004, 0x0cf8);
outl(0xcfc, 0x2); /*set the memory access enable bit*/ outl(0x2, 0xcfc); /*set the memory access enable bit*/
OUTC(0x0fffef072, 1); /* enable req bits in SYSARBMENB */ OUTC(0x0fffef072, 1); /* enable req bits in SYSARBMENB */
} }

2
src/southbridge/broadcom/bcm5785/bcm5785_sb_pci_main.c
View File

@ -38,7 +38,7 @@ static void sb_init(device_t dev)
byte |= ( 1 << 7); // Can not mask NMI from PCI-E and NMI_NOW byte |= ( 1 << 7); // Can not mask NMI from PCI-E and NMI_NOW
} }
if( byte != byte_old) { if( byte != byte_old) {
outb(0x70, byte); outb(byte, 0x70);
} }

2
src/southbridge/nvidia/ck804/ck804_lpc.c
View File

@ -245,7 +245,7 @@ static void lpc_init(device_t dev)
byte |= (1 << 7); /* Can't mask NMI from PCI-E and NMI_NOW. */ byte |= (1 << 7); /* Can't mask NMI from PCI-E and NMI_NOW. */
} }
if (byte != byte_old) if (byte != byte_old)
outb(0x70, byte); outb(byte, 0x70);
/* Initialize the real time clock (RTC). */ /* Initialize the real time clock (RTC). */
rtc_init(0); rtc_init(0);

2
src/southbridge/nvidia/mcp55/mcp55_lpc.c
View File

@ -230,7 +230,7 @@ static void lpc_init(device_t dev)
byte |= ( 1 << 7); // Can not mask NMI from PCI-E and NMI_NOW byte |= ( 1 << 7); // Can not mask NMI from PCI-E and NMI_NOW
} }
if( byte != byte_old) { if( byte != byte_old) {
outb(0x70, byte); outb(byte, 0x70);
} }
/* Initialize the real time clock */ /* Initialize the real time clock */

2
src/southbridge/sis/sis966/sis966_lpc.c
View File

@ -220,7 +220,7 @@ static void lpc_init(device_t dev)
byte |= ( 1 << 7); // Can not mask NMI from PCI-E and NMI_NOW byte |= ( 1 << 7); // Can not mask NMI from PCI-E and NMI_NOW
} }
if( byte != byte_old) { if( byte != byte_old) {
outb(0x70, byte); outb(byte, 0x70);
} }
/* Initialize the real time clock */ /* Initialize the real time clock */