GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

amd/agesa/f15/Lib/amdlib.c: Add missing breaks to switch statement 

Static analysis often flags case statements that do not include
a terminating "break;" statement. Eclipse's CODAN is an example
of this.  This changelist modifies amdlib.c to terminate
case statements with "break;".

Change-Id: I3d43acaf64e2e2d9717421cb547fec35e582cf8b
Signed-off-by: Bruce Griffith <Bruce.Griffith@se-eng.com>
Reviewed-on: http://review.coreboot.org/3539
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Bruce Griffith 2013-06-25 14:14:14 -06:00 committed by Stefan Reinauer
parent af881b898a
commit e44a89f6fd
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/vendorcode/amd/agesa/f15/Lib/amdlib.c
View File

@ -285,6 +285,7 @@ LibAmdReadCpuReg (
break;
default:
*Value = -1;
break;
}
}
VOID
@ -313,7 +314,7 @@ LibAmdWriteCpuReg (
__writedr (7, Value);
break;
default:
;
break;
}
}
VOID
@ -503,6 +504,7 @@ LibAmdIoRead (
break;
default:
ASSERT (FALSE);
break;
}
}
@ -540,6 +542,7 @@ LibAmdIoWrite (
break;
default:
ASSERT (FALSE);
break;
}
}
@ -640,6 +643,7 @@ LibAmdMemRead (
break;
default:
ASSERT (FALSE);
break;
}
}
@ -678,6 +682,7 @@ LibAmdMemWrite (
break;
default:
ASSERT (FALSE);
break;
}
}
/*---------------------------------------------------------------------------------------*/
@ -1293,6 +1298,7 @@ LibAmdGetDataFromPtr (
break;
default:
IDS_ERROR_TRAP;
break;
}
}
@ -1333,6 +1339,7 @@ LibAmdAccessWidth (
default:
Width = 0;
IDS_ERROR_TRAP;
break;
}
return Width;
}