GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

AMD CIMx SB800: late.c: Use variable `device` from for loop condition 

Use the variable `device` instead of `dev` in the predicate of
the if condition, as `dev` is not changed in the for loop.

The for loop was added in the following commit.

    commit 8fed77ae4c
    Author: Scott Duplichan <scott@notabs.org>
    Date:   Sat Jun 18 10:46:45 2011 -0500

        ASRock E350M1: Configure SB800 GPP ports to support onboard pcie nic

        Reviewed-on: http://review.coreboot.org/44

The assumption that the devices are ordered in the tree seem to
hold in this case (although it is not ensured) and therefore at
least with the ASRock E350M1 no (visible) change is experienced as
the children are all of type `DEVICE_PATH_PCI`.

Change-Id: Iaa2fa13305dbe924965d27680cd02fe30c2f58a5
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/2562
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Paul Menzel 2013-03-01 13:05:04 +01:00 committed by Kyösti Mälkki
parent 3dce9f09d9
commit e4a016ff17
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/southbridge/amd/cimx/sb800/late.c
View File

@ -428,9 +428,8 @@ static void sb800_enable(device_t dev)
case (0x15 << 3) | 0: /* 0:15:0 PCIe PortA */
{
device_t device;
for (device = dev; device; device = device->next) {
if (dev->path.type != DEVICE_PATH_PCI) continue;
if ((device->path.pci.devfn & ~7) != PCI_DEVFN(0x15,0)) break;
for (device = dev; device; device = device->sibling) {
if ((device->path.pci.devfn & ~3) != PCI_DEVFN(0x15,0)) break;
sb_config->PORTCONFIG[device->path.pci.devfn & 3].PortCfg.PortPresent = device->enabled;
}