From e4f7c8fce8fbb7bcbe2bdfc1e4e013eae1ccf4a4 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Fri, 18 Dec 2020 20:45:22 -0600 Subject: [PATCH] mb/google/eve: Use keyboard backlight for proof-of-life at boot This feature was originally present and then dropped, but turns out that users prefer it. Set the backlight to 50% in romstage, back to zero in ramstage; skip enabling on the S3 resume path. TEST=build/boot google/eve, verify keyboard backlight turns on/off as expected. Change-Id: I33af888d614010538f69512bbd052ed2b83fcaa5 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/76803 Tested-by: build bot (Jenkins) Reviewed-by: Felix Held --- src/mainboard/google/eve/ec.c | 4 ++++ src/mainboard/google/eve/romstage.c | 7 +++++++ 2 files changed, 11 insertions(+) diff --git a/src/mainboard/google/eve/ec.c b/src/mainboard/google/eve/ec.c index 499f56484b..7ed07460c8 100644 --- a/src/mainboard/google/eve/ec.c +++ b/src/mainboard/google/eve/ec.c @@ -15,4 +15,8 @@ void mainboard_ec_init(void) }; google_chromeec_events_init(&info, acpi_is_wakeup_s3()); + + /* Turn off keyboard backlight after turning on in romstage */ + if (!acpi_is_wakeup_s3()) + google_chromeec_kbbacklight(0); } diff --git a/src/mainboard/google/eve/romstage.c b/src/mainboard/google/eve/romstage.c index f3c0f1140b..906f98e0bb 100644 --- a/src/mainboard/google/eve/romstage.c +++ b/src/mainboard/google/eve/romstage.c @@ -1,11 +1,14 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include #include #include +#include #include #include #include #include "spd/spd.h" +#include "ec.h" void mainboard_memory_init_params(FSPM_UPD *mupd) { @@ -41,4 +44,8 @@ void mainboard_memory_init_params(FSPM_UPD *mupd) printk(BIOS_WARNING, "Limiting memory to 1600MHz\n"); mem_cfg->DdrFreqLimit = 1600; } + + /* Turn on keyboard backlight to indicate we are booting */ + if (!acpi_is_wakeup_s3()) + google_chromeec_kbbacklight(50); }