GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

armv7/exynos5250: place .id between .start and bootblock main 

This places the .id section toward the lower region of the coreboot
image, before the bootblock. It's easier for humans to find by dumping
the image and it also eliminates ID_SECTION_OFFSET which is currently
the upper bound on our image size.

Change-Id: I7d737b901dac659ddf9aa437cee5dc32f1080546
Signed-off-by: David Hendricks <dhendrix@chromium.org>
Reviewed-on: http://review.coreboot.org/2345
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
This commit is contained in:
David Hendricks 2013-02-09 14:58:45 -08:00 committed by Ronald G. Minnich
parent f5a302378a
commit e50e343470
5 changed files with 4 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/arch/armv7/Makefile.inc
View File

@ -202,7 +202,6 @@ $(obj)/coreboot.pre: $(objcbfs)/romstage_xip.elf $(obj)/coreboot.pre1 $(CBFSTOOL
# Build the bootblock # Build the bootblock
bootblock_lds = $(src)/arch/armv7/bootblock.lds bootblock_lds = $(src)/arch/armv7/bootblock.lds
bootblock_lds += $(src)/arch/armv7/lib/id.lds
bootblock_lds += $(chipset_bootblock_lds) bootblock_lds += $(chipset_bootblock_lds)
bootblock_inc += $(src)/arch/armv7/bootblock.inc bootblock_inc += $(src)/arch/armv7/bootblock.inc

1
src/arch/armv7/bootblock.lds
View File

@ -32,6 +32,7 @@ SECTIONS
_rom = .; _rom = .;
*(.bl1); *(.bl1);
*(.start); *(.start);
*(.id);
*(.text); *(.text);
*(.text.*); *(.text.*);
*(.rom.text); *(.rom.text);

6
src/arch/armv7/lib/id.inc
View File

@ -8,9 +8,9 @@ vendor:
.asciz CONFIG_MAINBOARD_VENDOR .asciz CONFIG_MAINBOARD_VENDOR
part: part:
.asciz CONFIG_MAINBOARD_PART_NUMBER .asciz CONFIG_MAINBOARD_PART_NUMBER
.long __id_end + CONFIG_ID_SECTION_OFFSET - ver /* Reverse offset to the vendor id */ .long __id_end - ver /* Reverse offset to the vendor id */
.long __id_end + CONFIG_ID_SECTION_OFFSET - vendor /* Reverse offset to the vendor id */ .long __id_end - vendor /* Reverse offset to the vendor id */
.long __id_end + CONFIG_ID_SECTION_OFFSET - part /* Reverse offset to the part number */ .long __id_end - part /* Reverse offset to the part number */
.long CONFIG_ROM_SIZE /* Size of this romimage */ .long CONFIG_ROM_SIZE /* Size of this romimage */
.globl __id_end .globl __id_end

6
src/arch/armv7/lib/id.lds
View File

@ -1,6 +0,0 @@
SECTIONS {
. = CONFIG_ID_SECTION_BASE;
.id (.): {
*(.id)
}
}

6
src/cpu/samsung/exynos5250/Kconfig
View File

@ -22,8 +22,6 @@ config BL1_SIZE_KB
# #
# 0x0202_0000: vendor-provided BL1 # 0x0202_0000: vendor-provided BL1
# 0x0202_3400: bootblock, assume up to 32KB in size # 0x0202_3400: bootblock, assume up to 32KB in size
# 0x0202_7000: ID section, assume 2KB in size. This will be
# within the bootblock section.
# 0x0203_0000: romstage, assume up to 128KB in size. # 0x0203_0000: romstage, assume up to 128KB in size.
# 0x0207_7f00: stack pointer # 0x0207_7f00: stack pointer
@ -40,10 +38,6 @@ config BOOTBLOCK_BASE
hex hex
default 0x02023400 default 0x02023400
config ID_SECTION_BASE
hex
default 0x02027e00
config ROMSTAGE_BASE config ROMSTAGE_BASE
hex hex
default 0x02030000 default 0x02030000