GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

baytrail: IOSF write functions need to set data before control 

The data needs to be available in the register before the control
bits are set to make the write happen.

BUG=chrome-os-partner:23507
BRANCH=rambi
TEST=successfully ungate power on PUNIT on rambi

Change-Id: I8fae60d5385ce9a401c1dec9cbb39b70d157a6c2
Signed-off-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/174898
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: http://review.coreboot.org/4906
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
This commit is contained in:
Duncan Laurie 2013-10-28 14:18:38 -07:00 committed by Aaron Durbin
parent 063c873588
commit e549e94d03
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/soc/intel/baytrail/iosf.c
View File

@ -56,8 +56,8 @@ void iosf_bunit_write(int reg, uint32_t val)
uint32_t cr = IOSF_OPCODE(IOSF_OP_WRITE_BUNIT) |
IOSF_PORT(IOSF_PORT_BUNIT) | IOSF_REG(reg) | IOSF_BYTE_EN;
write_iosf_reg(MCR_REG, cr);
write_iosf_reg(MDR_REG, val);
write_iosf_reg(MCR_REG, cr);
}
uint32_t iosf_dunit_read(int reg)
@ -91,8 +91,8 @@ void iosf_dunit_write(int reg, uint32_t val)
IOSF_PORT(IOSF_PORT_SYSMEMC) | IOSF_REG(reg) |
IOSF_BYTE_EN;
write_iosf_reg(MCR_REG, cr);
write_iosf_reg(MDR_REG, val);
write_iosf_reg(MCR_REG, cr);
}
uint32_t iosf_punit_read(int reg)
@ -111,6 +111,6 @@ void iosf_punit_write(int reg, uint32_t val)
IOSF_PORT(IOSF_PORT_PMC) | IOSF_REG(reg) |
IOSF_BYTE_EN;
write_iosf_reg(MCR_REG, cr);
write_iosf_reg(MDR_REG, val);
write_iosf_reg(MCR_REG, cr);
}