From e64a585374de88ea896ed517445a34986aa321b9 Mon Sep 17 00:00:00 2001 From: Julius Werner Date: Mon, 15 Oct 2018 17:19:58 -0700 Subject: [PATCH] console: Set default loglevel to 8 (SPEW) for CONFIG_CHROMEOS CB:26053 changed coreboot's default loglevel from SPEW to DEBUG. This may be the most reasonable choice for most users that are mostly interested in the UART console. However, on Chrome OS devices the UART is disabled for production configurations anyway, and instead they rely heavily on the CBMEM console for remote debugging and bug reports. For these kinds of cases more info is almost always better, and you can't easily reproduce a remotely filed bug if you notice that you need some info that is only provided by BIOS_SPEW. On the other hand, the cost of logging extra info to the CBMEM console is pretty negligible. Therefore, let's bump the loglevel for CONFIG_CHROMEOS in particular back up to the maximum. (Unfortunately, it seems that you can't 'select' a choice option from another option, so this has to go in the console/Kconfig file.) Change-Id: I50724e3f7f8f57fdbc5846f21babc71798b21b65 Signed-off-by: Julius Werner Reviewed-on: https://review.coreboot.org/29144 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber Reviewed-by: Angel Pons Reviewed-by: Aaron Durbin --- src/console/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/src/console/Kconfig b/src/console/Kconfig index febed9504d..318ca187ca 100644 --- a/src/console/Kconfig +++ b/src/console/Kconfig @@ -308,6 +308,7 @@ if !CONSOLE_OVERRIDE_LOGLEVEL choice prompt "Default console log level" + default DEFAULT_CONSOLE_LOGLEVEL_8 if CHROMEOS default DEFAULT_CONSOLE_LOGLEVEL_7 config DEFAULT_CONSOLE_LOGLEVEL_8