GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/meteorlake: Improve `incomplete` debug message 

This patch improves `incomplete` debug messages for missing ACPI
name PCI devices.

Additionally, using the proper PCI device B:D:F to locate the device
with the missing ACPI name.

Finally, modify the msg time from Debug to Warning to make it more
purposeful.

TEST=Able to build and boot google/rex.

Without this patch:

```
  [DEBUG]  dev->path.devfn=10
  [DEBUG]  dev->path.devfn=a2
  [DEBUG]  dev->path.devfn=b0
```

With this patch:

```
  [WARN]  Missing ACPI Name for PCI: 00:02.0
  [WARN]  Missing ACPI Name for PCI: 00:14.2
  [WARN]  Missing ACPI Name for PCI: 00:16.0
```

Change-Id: I605e59de8cbec18c9a56eaa6e90a34f36ea4cdd9
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73072
Reviewed-by: Tarun Tuli <taruntuli@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Reviewed-by: Ivy Jian <ivy.jian@quanta.corp-partner.google.com>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
This commit is contained in:
Subrata Banik 2023-02-17 03:18:50 +05:30
parent 8b223d43ce
commit e70bc423f9
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/soc/intel/meteorlake/chip.c
View File

@ -113,7 +113,8 @@ const char *soc_acpi_name(const struct device *dev)
case PCI_DEVFN_SMBUS: return "SBUS";
case PCI_DEVFN_GBE: return "GLAN";
}
printk(BIOS_DEBUG, "dev->path.devfn=%x\n", dev->path.pci.devfn);
printk(BIOS_DEBUG, "Missing ACPI Name for PCI: 00:%02x.%01x\n",
PCI_SLOT(dev->path.pci.devfn), PCI_FUNC(dev->path.pci.devfn));
return NULL;
}
#endif