GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Replace ramtest pattern to assist in DIMM configuration 

This is developer's testtool. Output from a "rotate ones" -style
pattern helps figure out how DIMM addresses are encoded or routed
on a certain mainboard.

Scattered test should cover every data and address lines on the memory
bus, but is probably limited to the first bank of first DIMM.

Change-Id: I533a7a873bcc434f99e7faed9dc9337d9ab64196
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
[pg: rebase]
Reviewed-on: http://review.coreboot.org/294
Tested-by: build bot (Jenkins)
Reviewed-by: Rudolf Marek <r.marek@assembler.cz>
This commit is contained in:
Kyösti Mälkki 2012-03-17 08:09:14 +01:00 committed by Rudolf Marek
parent 8a85bccd84
commit e77b9a0ab7
1 changed files with 96 additions and 93 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

187
src/lib/ramtest.c
View File

@ -47,100 +47,114 @@ static void phys_memory_barrier(void)
#endif #endif
} }
static void ram_fill(unsigned long start, unsigned long stop) /**
{ * Rotate ones test pattern that access every bit on a 128bit wide
unsigned long addr; * memory bus. To test most address lines, addresses are scattered
/* * using 256B, 4kB and 64kB increments.
* Fill. *
* @idx Index to test pattern (0=<idx<0x400)
* @addr Memory to access on @idx
* @value Value to write or read at @addr
*/ */
#if !defined(__ROMCC__) static inline void test_pattern(unsigned short int idx,
printk(BIOS_DEBUG, "DRAM fill: 0x%08lx-0x%08lx\n", start, stop); unsigned long *addr, unsigned long *value)
#else {
print_debug("DRAM fill: "); uint8_t j, k;
print_debug_hex32(start);
print_debug("-"); k = (idx >> 8) + 1;
print_debug_hex32(stop); j = (idx >> 4) & 0x0f;
print_debug("\n"); *addr = idx & 0x0f;
#endif *addr |= j << (4*k);
for(addr = start; addr < stop ; addr += 4) { *value = 0x01010101 << (j & 7);
/* Display address being filled */ if (j & 8)
if (!(addr & 0xfffff)) { *value = ~(*value);
#if !defined(__ROMCC__)
printk(BIOS_DEBUG, "%08lx \r", addr);
#else
print_debug_hex32(addr);
print_debug(" \r");
#endif
}
write_phys(addr, (u32)addr);
};
/* Display final address */
#if !defined(__ROMCC__)
printk(BIOS_DEBUG, "%08lx\nDRAM filled\n", addr);
#else
print_debug_hex32(addr);
print_debug("\nDRAM filled\n");
#endif
} }
static int ram_verify_nodie(unsigned long start, unsigned long stop) /**
{ * Simple write-read-verify memory test. See console debug output for
unsigned long addr; * any dislocated bytes.
int i = 0; *
/* * @start System memory offset, aligned to 128bytes
* Verify.
*/ */
static int ram_bitset_nodie(unsigned long start)
{
unsigned long addr, value, value2;
unsigned short int idx;
unsigned char failed, failures;
uint8_t verbose = 0;
#if !defined(__ROMCC__) #if !defined(__ROMCC__)
printk(BIOS_DEBUG, "DRAM verify: 0x%08lx-0x%08lx\n", start, stop); printk(BIOS_DEBUG, "DRAM bitset write: 0x%08lx\n", start);
#else #else
print_debug("DRAM verify: "); print_debug("DRAM bitset write: 0x");
print_debug_hex32(start); print_debug_hex32(start);
print_debug_char('-');
print_debug_hex32(stop);
print_debug("\n"); print_debug("\n");
#endif #endif
for(addr = start; addr < stop ; addr += 4) { for (idx=0; idx<0x400; idx+=4) {
unsigned long value; test_pattern(idx, &addr, &value);
/* Display address being tested */ write_phys(start + addr, value);
if (!(addr & 0xfffff)) {
#if !defined(__ROMCC__)
printk(BIOS_DEBUG, "%08lx \r", addr);
#else
print_debug_hex32(addr);
print_debug(" \r");
#endif
} }
value = read_phys(addr);
if (value != addr) { /* Make sure we don't read before we wrote */
/* Display address with error */ phys_memory_barrier();
#if !defined(__ROMCC__) #if !defined(__ROMCC__)
printk(BIOS_ERR, "Fail: @0x%08lx Read value=0x%08lx\n", addr, value); printk(BIOS_DEBUG, "DRAM bitset verify: 0x%08lx\n", start);
#else #else
print_err("Fail: @0x"); print_debug("DRAM bitset verify: 0x");
print_err_hex32(addr); print_debug_hex32(start);
print_err(" Read value=0x"); print_debug("\n");
#endif
failures = 0;
for (idx=0; idx<0x400; idx+=4) {
test_pattern(idx, &addr, &value);
value2 = read_phys(start + addr);
failed = (value2 != value);
failures |= failed;
if (failed && !verbose) {
#if !defined(__ROMCC__)
printk(BIOS_ERR, "0x%08lx wr: 0x%08lx rd: 0x%08lx FAIL\n",
start + addr, value, value2);
#else
print_err_hex32(start + addr);
print_err(" wr: 0x");
print_err_hex32(value); print_err_hex32(value);
print_err("\n"); print_err(" rd: 0x");
print_err_hex32(value2);
print_err(" FAIL\n");
#endif #endif
i++; }
if(i>256) { if (verbose) {
#if !defined(__ROMCC__) #if !defined(__ROMCC__)
printk(BIOS_DEBUG, "Aborting.\n"); if ((addr & 0x0f) == 0)
printk(BIOS_DEBUG, "%08lx wr: %08lx rd:",
start + addr, value);
if (failed)
printk(BIOS_DEBUG, " %08lx!", value2);
else
printk(BIOS_DEBUG, " %08lx ", value2);
if ((addr & 0x0f) == 0xc)
printk(BIOS_DEBUG, "\n");
#else #else
print_debug("Aborting.\n"); if ((addr & 0x0f) == 0) {
print_dbg_hex32(start + addr);
print_dbg(" wr: ");
print_dbg_hex32(value);
print_dbg(" rd: ");
}
print_dbg_hex32(value2);
if (failed)
print_dbg("! ");
else
print_dbg(" ");
if ((addr & 0x0f) == 0xc)
print_dbg("\n");
#endif #endif
break;
} }
} }
} if (failures) {
/* Display final address */ post_code(0xea);
#if !defined(__ROMCC__)
printk(BIOS_DEBUG, "%08lx", addr);
#else
print_debug_hex32(addr);
#endif
if (i) {
#if !defined(__ROMCC__) #if !defined(__ROMCC__)
printk(BIOS_DEBUG, "\nDRAM did _NOT_ verify!\n"); printk(BIOS_DEBUG, "\nDRAM did _NOT_ verify!\n");
#else #else
@ -168,18 +182,13 @@ void ram_check(unsigned long start, unsigned long stop)
* are tested. -Tyson * are tested. -Tyson
*/ */
#if !defined(__ROMCC__) #if !defined(__ROMCC__)
printk(BIOS_DEBUG, "Testing DRAM : %08lx - %08lx\n", start, stop); printk(BIOS_DEBUG, "Testing DRAM at: %08lx\n", start);
#else #else
print_debug("Testing DRAM : "); print_debug("Testing DRAM at: ");
print_debug_hex32(start); print_debug_hex32(start);
print_debug("-");
print_debug_hex32(stop);
print_debug("\n"); print_debug("\n");
#endif #endif
ram_fill(start, stop); if (ram_bitset_nodie(start))
/* Make sure we don't read before we wrote */
phys_memory_barrier();
if (ram_verify_nodie(start, stop))
die("DRAM ERROR"); die("DRAM ERROR");
#if !defined(__ROMCC__) #if !defined(__ROMCC__)
printk(BIOS_DEBUG, "Done.\n"); printk(BIOS_DEBUG, "Done.\n");
@ -198,19 +207,14 @@ int ram_check_nodie(unsigned long start, unsigned long stop)
* are tested. -Tyson * are tested. -Tyson
*/ */
#if !defined(__ROMCC__) #if !defined(__ROMCC__)
printk(BIOS_DEBUG, "Testing DRAM : %08lx - %08lx\n", start, stop); printk(BIOS_DEBUG, "Testing DRAM at : %08lx\n", start);
#else #else
print_debug("Testing DRAM : "); print_debug("Testing DRAM at : ");
print_debug_hex32(start); print_debug_hex32(start);
print_debug("-");
print_debug_hex32(stop);
print_debug("\n"); print_debug("\n");
#endif #endif
ram_fill(start, stop);
/* Make sure we don't read before we wrote */
phys_memory_barrier();
ret = ram_verify_nodie(start, stop);
ret = ram_bitset_nodie(start);
#if !defined(__ROMCC__) #if !defined(__ROMCC__)
printk(BIOS_DEBUG, "Done.\n"); printk(BIOS_DEBUG, "Done.\n");
#else #else
@ -248,4 +252,3 @@ void quick_ram_check(void)
} }
phys_memory_barrier(); phys_memory_barrier();
} }