From e7a0202ed04db7aa5033e659345ccc75c3bc0773 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Thu, 10 Dec 2020 02:05:47 +0100 Subject: [PATCH] soc/amd/piasso,cezanne: add warning about using all-y in Makefile.inc all-y will also add a compilation unit to the verstage on PSP build that runs on an ARM code instead of a x86 one. At the moment Cezanne doesn't have verstage on PSP support yet, but since it'll eventually land it doesn't hurt to already add the comment now. Change-Id: I15fb66e796cab48737ba5ac463c4c973794a005a Signed-off-by: Felix Held Reviewed-on: https://review.coreboot.org/c/coreboot/+/48521 Tested-by: build bot (Jenkins) Reviewed-by: Marshall Dawson --- src/soc/amd/cezanne/Makefile.inc | 1 + src/soc/amd/picasso/Makefile.inc | 1 + 2 files changed, 2 insertions(+) diff --git a/src/soc/amd/cezanne/Makefile.inc b/src/soc/amd/cezanne/Makefile.inc index 946e48004b..e7d0aea560 100644 --- a/src/soc/amd/cezanne/Makefile.inc +++ b/src/soc/amd/cezanne/Makefile.inc @@ -2,6 +2,7 @@ ifeq ($(CONFIG_SOC_AMD_CEZANNE),y) +# Beware that all-y also adds the compilation unit to verstage on PSP all-y += config.c bootblock-y += bootblock.c diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.inc index 7cbae92932..142fb0c1f0 100644 --- a/src/soc/amd/picasso/Makefile.inc +++ b/src/soc/amd/picasso/Makefile.inc @@ -9,6 +9,7 @@ subdirs-y += ../../../cpu/x86/pae subdirs-y += ../../../cpu/x86/smm subdirs-$(CONFIG_VBOOT_STARTS_BEFORE_BOOTBLOCK) += psp_verstage +# Beware that all-y also adds the compilation unit to verstage on PSP all-y += config.c all-y += aoac.c