From e8118acfbee788f1c45319970a6a10dfc8f30491 Mon Sep 17 00:00:00 2001 From: Stanley Wu Date: Thu, 18 Feb 2021 21:02:30 +0800 Subject: [PATCH] mb/google/dedede/var/boten: route GPP_E11 via APIC MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit GPP_E11 should be configured to be routed via APIC to avoid p-sensor communication error in OS. BUG=b:178465379 BRANCH=dedede TEST=run "i2cdump -y -f 15 0x28" to confirm registers as expected. un-approach： => register address: 0x01 value: 0x00 approach: => register address: 0x01 value: 0x02 verify sx932x IRQ in "/proc/interrupts" loading as expected. Change-Id: I7d639ec1f9b31b240475dc1c8025bf59ae1e8e0b Signed-off-by: Stanley Wu Reviewed-on: https://review.coreboot.org/c/coreboot/+/50876 Reviewed-by: Karthik Ramasubramanian Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) --- src/mainboard/google/dedede/variants/boten/gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mainboard/google/dedede/variants/boten/gpio.c b/src/mainboard/google/dedede/variants/boten/gpio.c index ee3a4e3fad..6046acb94f 100644 --- a/src/mainboard/google/dedede/variants/boten/gpio.c +++ b/src/mainboard/google/dedede/variants/boten/gpio.c @@ -48,7 +48,7 @@ static const struct pad_config gpio_table[] = { /* E2 : CLK_24M_WCAM */ PAD_NC(GPP_E2, NONE), /* E11 : AP_I2C_SUB_INT_ODL */ - PAD_CFG_GPI_INT(GPP_E11, NONE, PLTRST, EDGE_BOTH), + PAD_CFG_GPI_APIC(GPP_E11, NONE, PLTRST, LEVEL, NONE), /* H6 : AP_I2C_CAM_SDA */ PAD_NC(GPP_H6, NONE),