From e8183599aec0d09789da40fb720339f9f42a53df Mon Sep 17 00:00:00 2001 From: Zheng Bao Date: Wed, 1 Mar 2023 12:35:14 +0800 Subject: [PATCH] commit-msg: Match the Signed-off-by line with name and mail address The previous regular expression only matches the line starting with "Signed-off-by:". If the name and mail address are missing, it can not find out. The following words should be "name ". Change-Id: I42cc399e79b65928a6aef87c51e5476c7158d166 Signed-off-by: Zheng Bao Reviewed-on: https://review.coreboot.org/c/coreboot/+/73340 Tested-by: build bot (Jenkins) Reviewed-by: Lean Sheng Tan --- util/gitconfig/commit-msg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/gitconfig/commit-msg b/util/gitconfig/commit-msg index 99c8941be4..08f04ffe8d 100755 --- a/util/gitconfig/commit-msg +++ b/util/gitconfig/commit-msg @@ -166,7 +166,7 @@ _gen_ChangeId() { git hash-object -t commit --stdin } -if ! grep -qi '^[[:space:]]*Signed-off-by:' "$MSG"; then +if ! grep -qi '^[[:space:]]*Signed-off-by:.\+<.\+@.\+>' "$MSG"; then printf "\nError: No Signed-off-by line in the commit message.\n" exit 1 fi