From e87ec095a427ab12b2c1665d6dcd23cb81bf311b Mon Sep 17 00:00:00 2001 From: Aaron Durbin Date: Mon, 17 Aug 2020 17:34:10 -0600 Subject: [PATCH] soc/amd/picasso: fix GPE snapshot state In CB:44488 the cbmem addition was re-filling the object when it should be memcpy()ing from static object. Correct that oversight. The side effect from the previous implementation would be if FSP-M modified the GPE state. BUG=b:159947207 Signed-off-by: Aaron Durbin Change-Id: I158a89ae28431896fa9b5789292000fcbf0b066d Reviewed-on: https://review.coreboot.org/c/coreboot/+/44533 Reviewed-by: Furquan Shaikh Tested-by: build bot (Jenkins) --- src/soc/amd/picasso/romstage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/amd/picasso/romstage.c b/src/soc/amd/picasso/romstage.c index 61782204e3..5a9f051968 100644 --- a/src/soc/amd/picasso/romstage.c +++ b/src/soc/amd/picasso/romstage.c @@ -31,7 +31,7 @@ static void add_chipset_state_cbmem(int unused) state = cbmem_add(CBMEM_ID_POWER_STATE, sizeof(*state)); if (state) - acpi_fill_pm_gpe_state(state); + memcpy(state, &chipset_state, sizeof(*state)); } ROMSTAGE_CBMEM_INIT_HOOK(add_chipset_state_cbmem);