GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/volteer: Change wake to be triggered on a raising edge 

ACPI_GPIO_IRQ_EDGE_BOTH sets both edges as wake. The desired behavior is wake on rising edge, change to ACPI_GPIO_INPUT_ACTIVE_LOW.

Fixing for both Volteer and Volteer2 variants.

BUG=b:146083964
BRANCH=None
TEST=tested on a Volteer

Change-Id: I2d3339151bf4e2cbae60aaf97ba1bd7909a2b9a9
Signed-off-by: Alex Levin <levinale@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44089
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
This commit is contained in:
Alex Levin 2020-07-31 13:05:57 -07:00 committed by Patrick Georgi
parent 6588652ef5
commit e968e3762e
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/google/volteer/variants/volteer/overridetree.cb
View File

@ -114,7 +114,7 @@ chip soc/intel/tigerlake
chip drivers/generic/gpio_keys
register "name" = ""PENH""
# GPP_B3 is the IRQ source, and GPP_E1 is the wake source
register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_B3)"
register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_B3)"
register "key.wake_gpe" = "GPE0_DW2_01"
register "key.wakeup_route" = "WAKEUP_ROUTE_SCI"
register "key.wakeup_event_action" = "EV_ACT_DEASSERTED"

2
src/mainboard/google/volteer/variants/volteer2/overridetree.cb
View File

@ -70,7 +70,7 @@ chip soc/intel/tigerlake
chip drivers/generic/gpio_keys
register "name" = ""PENH""
# GPP_B3 is the IRQ source, and GPP_E1 is the wake source
register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_B3)"
register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_B3)"
register "key.wake_gpe" = "GPE0_DW2_01"
register "key.wakeup_route" = "WAKEUP_ROUTE_SCI"
register "key.wakeup_event_action" = "EV_ACT_DEASSERTED"