intel/meteorlake: remove skip_mbp_hob SOC chip config

Introduce at new config option CONFIG_FSP_PUBLISH_MBP_HOB to
control the creation of ME_BIOS_PAYLOAD_HOB (MBP HOB) by FSP.

This new option is hooked with `SkipMbpHob` UPD and is always
disabled for ChromeOS platforms.

This made skip_mbp_hob SOC chip config variable redundant
which is also removed as part of this change.

BUG=none
TEST=Build and boot to Google/Rex.

Signed-off-by: Kapil Porwal <kapilporwal@google.com>
Change-Id: Iaba1ea29a92a63d2b287e1ccdea1a81ec07b9971
Reviewed-on: https://review.coreboot.org/c/coreboot/+/71997
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
This commit is contained in:
Kapil Porwal 2023-01-16 16:41:49 +00:00 committed by Subrata Banik
parent b10a4bf002
commit e988cc20b6
4 changed files with 9 additions and 9 deletions

View File

@ -70,8 +70,6 @@ chip soc/intel/meteorlake
[PchSerialIoIndexI2C5] = PchSerialIoPci,
}"
register "skip_mbp_hob" = "1"
# Intel Common SoC Config
#+-------------------+---------------------------+
#| Field | Value |

View File

@ -371,4 +371,12 @@ config MTL_USE_COREBOOT_MP_INIT
endchoice
config FSP_PUBLISH_MBP_HOB
bool
default n if CHROMEOS
default y
help
This is to control creation of ME_BIOS_PAYLOAD_HOB (MBP HOB) by FSP.
Disabling it for the platforms, which do not use MBP HOB, can improve the boot time.
endif

View File

@ -352,12 +352,6 @@ struct soc_intel_meteorlake_config {
* Set this to 1 in order to disable Package C-state demotion.
*/
bool disable_package_c_state_demotion;
/*
* Enable or Disable Skipping MBP HOB.
* Default is set to 0 and set to 1 to skip the MBP HOB.
*/
bool skip_mbp_hob;
};
typedef struct soc_intel_meteorlake_config config_t;

View File

@ -187,7 +187,7 @@ static void fill_fspm_misc_params(FSP_M_CONFIG *m_cfg,
m_cfg->GpioOverride = 0x1;
/* Skip MBP HOB */
m_cfg->SkipMbpHob = config->skip_mbp_hob;
m_cfg->SkipMbpHob = !CONFIG(FSP_PUBLISH_MBP_HOB);
}
static void fill_fspm_audio_params(FSP_M_CONFIG *m_cfg,