From e99c1985d587a8983917baf4c9a0609178eca109 Mon Sep 17 00:00:00 2001 From: Jacob Garber Date: Mon, 24 Jun 2019 16:32:19 -0600 Subject: [PATCH] device/hypertransport.c: Remove dead assignment last_unitid is immediately overwritten in the do loop, so this assignment is not needed. This a relic from old code that commit 13f1c2af8b made obsolete, but was never removed. Change-Id: I2eecddd025f7a64b0a70fc07a61ebb43aba757d6 Signed-off-by: Jacob Garber Found-by: scan-build 8.0.0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/34292 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- src/device/hypertransport.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/device/hypertransport.c b/src/device/hypertransport.c index ccad5ce5a5..027c3ef1d4 100644 --- a/src/device/hypertransport.c +++ b/src/device/hypertransport.c @@ -291,7 +291,6 @@ static unsigned int do_hypertransport_scan_chain(struct bus *bus, unsigned min_d prev.freq_cap_off = PCI_HT_CAP_HOST_FREQ_CAP; /* If present, assign unitid to a hypertransport chain. */ - last_unitid = min_unitid -1; max_unitid = next_unitid = min_unitid; do { u8 pos;