From e9f4e56435a1c4904396577a0c031c91f7a64b15 Mon Sep 17 00:00:00 2001 From: Sridhar Siricilla Date: Fri, 5 May 2023 10:50:43 +0530 Subject: [PATCH] soc/intel/common: Define enum types for MKHI group IDs and ME SKUs The patch defines enum type for MKHI group IDs and ME SKU types instead of macros. TEST=Build code for Rex Signed-off-by: Sridhar Siricilla Change-Id: I102e802938a6a664a43a362d90a26755cff8f316 Reviewed-on: https://review.coreboot.org/c/coreboot/+/74996 Tested-by: build bot (Jenkins) Reviewed-by: Harsha B R Reviewed-by: Anil Kumar K Reviewed-by: Ronak Kanabar --- .../common/block/include/intelblocks/cse.h | 20 +++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/src/soc/intel/common/block/include/intelblocks/cse.h b/src/soc/intel/common/block/include/intelblocks/cse.h index c893846e19..23a449086c 100644 --- a/src/soc/intel/common/block/include/intelblocks/cse.h +++ b/src/soc/intel/common/block/include/intelblocks/cse.h @@ -8,11 +8,13 @@ #include /* MKHI Command groups */ -#define MKHI_GROUP_ID_CBM 0x0 -#define MKHI_GROUP_ID_HMRFPO 0x5 -#define MKHI_GROUP_ID_GEN 0xff -#define MKHI_GROUP_ID_BUP_COMMON 0xf0 -#define MKHI_GROUP_ID_FWCAPS 0x3 +enum mkhi_group_id { + MKHI_GROUP_ID_CBM = 0x0, + MKHI_GROUP_ID_HMRFPO = 0x5, + MKHI_GROUP_ID_GEN = 0xff, + MKHI_GROUP_ID_BUP_COMMON = 0xf0, + MKHI_GROUP_ID_FWCAPS = 0x3, +}; /* Global Reset Command ID */ #define MKHI_CBM_GLOBAL_RESET_REQ 0xb @@ -69,9 +71,11 @@ #define ME_DISABLE_ATTEMPTS 3 /* ME Firmware SKU Types */ -#define ME_HFS3_FW_SKU_CONSUMER 0x2 -#define ME_HFS3_FW_SKU_CORPORATE 0x3 -#define ME_HFS3_FW_SKU_LITE 0x5 +enum me_fw_sku { + ME_HFS3_FW_SKU_CONSUMER = 0x2, + ME_HFS3_FW_SKU_CORPORATE = 0x3, + ME_HFS3_FW_SKU_LITE = 0x5, +}; /* Number of cse boot performance data */ #define NUM_CSE_BOOT_PERF_DATA 64