GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/poppy/variants/atlas: Do not override icc_max 

Skylake SoC code now sets the icc_max based on the CPU SKU, so we
should not hard-code it in the device tree.

BUG=b:110890675
BRANCH=None
TEST=boots on atlas

Change-Id: I7eb3499b7bea9ab2c49e1f299e2dbb688c8d1c33
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://review.coreboot.org/27791
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Gaggery Tsai <gaggery.tsai@intel.com>
This commit is contained in:
Caveh Jalali 2018-08-01 18:53:29 -07:00 committed by Nico Huber
parent 248c60a672
commit ea45ecfb89
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/mainboard/google/poppy/variants/atlas/devicetree.cb
View File

@ -86,7 +86,7 @@ chip soc/intel/skylake
#| Psi4Enable | 1 | 1 | 1 | 1 | #| Psi4Enable | 1 | 1 | 1 | 1 |
#| ImonSlope | 0 | 0 | 0 | 0 | #| ImonSlope | 0 | 0 | 0 | 0 |
#| ImonOffset | 0 | 0 | 0 | 0 | #| ImonOffset | 0 | 0 | 0 | 0 |
#| IccMax | 4A | 24A | 24A | 24A | #| IccMax | set by SoC code per CPU SKU |
#| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V | #| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V |
#| AcLoadline | 14.75 | 4.42 | 4.7 | 4.7 | #| AcLoadline | 14.75 | 4.42 | 4.7 | 4.7 |
#| DcLoadline | 14.2 | 4.2 | 4.41 | 4.41 | #| DcLoadline | 14.2 | 4.2 | 4.41 | 4.41 |
@ -100,7 +100,6 @@ chip soc/intel/skylake
.psi4enable = 1, .psi4enable = 1,
.imon_slope = 0x0, .imon_slope = 0x0,
.imon_offset = 0x0, .imon_offset = 0x0,
.icc_max = VR_CFG_AMP(4),
.voltage_limit = 1520, .voltage_limit = 1520,
.ac_loadline = 1475, .ac_loadline = 1475,
.dc_loadline = 1420, .dc_loadline = 1420,
@ -115,7 +114,6 @@ chip soc/intel/skylake
.psi4enable = 1, .psi4enable = 1,
.imon_slope = 0x0, .imon_slope = 0x0,
.imon_offset = 0x0, .imon_offset = 0x0,
.icc_max = VR_CFG_AMP(24),
.voltage_limit = 1520, .voltage_limit = 1520,
.ac_loadline = 442, .ac_loadline = 442,
.dc_loadline = 420, .dc_loadline = 420,
@ -130,7 +128,6 @@ chip soc/intel/skylake
.psi4enable = 1, .psi4enable = 1,
.imon_slope = 0x0, .imon_slope = 0x0,
.imon_offset = 0x0, .imon_offset = 0x0,
.icc_max = VR_CFG_AMP(24),
.voltage_limit = 1520, .voltage_limit = 1520,
.ac_loadline = 470, .ac_loadline = 470,
.dc_loadline = 441, .dc_loadline = 441,
@ -145,7 +142,6 @@ chip soc/intel/skylake
.psi4enable = 1, .psi4enable = 1,
.imon_slope = 0x0, .imon_slope = 0x0,
.imon_offset = 0x0, .imon_offset = 0x0,
.icc_max = VR_CFG_AMP(24),
.voltage_limit = 1520, .voltage_limit = 1520,
.ac_loadline = 470, .ac_loadline = 470,
.dc_loadline = 441, .dc_loadline = 441,