GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

intel/common/block: Fix issues found by klockwork 

src/soc/intel/common/block/cpu/mp_init.c
  Function init_cpus: Pointer dev checked for NULL may be
  dereferenced.

src/soc/intel/common/block/graphics/graphics.c
  Function graphics_get_bar: Pointer dev returned from
  call may be NULL and will be dereferenced.

BRANCH=None
TEST=Built & booted Yorp board.

Change-Id: I5e7caa15a3911e05ff346d338493673af5318a51
Signed-off-by: John Zhao <john.zhao@intel.com>
Reviewed-on: https://review.coreboot.org/28060
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
John Zhao 2018-08-13 09:45:37 -07:00 committed by Felix Held
parent ddcf5a05e3
commit eac84ca35c
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/soc/intel/common/block/cpu/mp_init.c
View File

@ -134,7 +134,8 @@ static void init_cpus(void *unused)
microcode_patch = intel_microcode_find();
intel_microcode_load_unlocked(microcode_patch);
soc_init_cpus(dev->link_list);
if (dev && dev->link_list)
soc_init_cpus(dev->link_list);
}
static void wrapper_x86_setup_mtrrs(void *unused)

4
src/soc/intel/common/block/graphics/graphics.c
View File

@ -15,6 +15,7 @@
*/
#include <compiler.h>
#include <assert.h>
#include <console/console.h>
#include <device/pci.h>
#include <device/pci_ids.h>
@ -36,9 +37,10 @@ static uintptr_t graphics_get_bar(unsigned long index)
{
struct device *dev = SA_DEV_IGD;
struct resource *gm_res;
assert(dev != NULL);
/* Check if Graphics PCI device is disabled */
if (!dev->enabled)
if (!dev || !dev->enabled)
return 0;
gm_res = find_resource(dev, index);