GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/brya/var/felwinter: Correct USB3 TCSS setting 

Based on Intel Kit#615686, USB3 only needs to disable TBT and DMA per
port. And if uses USB3 directly you need to set TcssAuxOri accordingly.

BUG=b:206716691,b:205235144
TEST=USB function work as expected at USB3 only sku.

Signed-off-by: Eric Lai <ericr_lai@compal.corp-partner.google.com>
Change-Id: I303d042d6c80194ff48130fe4e9c04b49ca13ee8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/59385
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
This commit is contained in:
Eric Lai 2021-11-17 15:58:25 +08:00 committed by Felix Held
parent 88295c35cc
commit eae7bf2327
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/mainboard/google/brya/variants/felwinter/overridetree.cb
View File

@ -38,6 +38,12 @@ chip soc/intel/alderlake
device domain 0 on device domain 0 on
device ref dtt on end device ref dtt on end
device ref tbt_pcie_rp0 off end device ref tbt_pcie_rp0 off end
device ref tbt_pcie_rp1 on
probe DB_USB USB4_KB8001
end
device ref tbt_pcie_rp2 on
probe DB_USB USB4_KB8001
end
device ref cnvi_wifi on device ref cnvi_wifi on
chip drivers/wifi/generic chip drivers/wifi/generic
register "wake" = "GPE0_PME_B0" register "wake" = "GPE0_PME_B0"
@ -45,6 +51,7 @@ chip soc/intel/alderlake
end end
end end
device ref tcss_dma0 on device ref tcss_dma0 on
probe DB_USB USB4_KB8001
chip drivers/intel/usb4/retimer chip drivers/intel/usb4/retimer
register "dfp[0].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E4)" register "dfp[0].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E4)"
use tcss_usb3_port2 as dfp[0].typec_port use tcss_usb3_port2 as dfp[0].typec_port
@ -52,12 +59,11 @@ chip soc/intel/alderlake
end end
end end
device ref tcss_dma1 on device ref tcss_dma1 on
probe DB_USB USB4_KB8001
chip drivers/intel/usb4/retimer chip drivers/intel/usb4/retimer
register "dfp[0].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E4)" register "dfp[0].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E4)"
use tcss_usb3_port3 as dfp[0].typec_port use tcss_usb3_port3 as dfp[0].typec_port
device generic 0 on device generic 0 on end
probe DB_USB USB4_KB8001
end
end end
end end
device ref pcie_rp6 off end device ref pcie_rp6 off end

1
src/mainboard/google/brya/variants/felwinter/variant.c
View File

@ -9,5 +9,6 @@ void variant_update_soc_chip_config(struct soc_intel_alderlake_config *config)
if (fw_config_probe(FW_CONFIG(DB_USB, USB3_PS8815))) { if (fw_config_probe(FW_CONFIG(DB_USB, USB3_PS8815))) {
config->typec_aux_bias_pads[2].pad_auxp_dc = GPP_A19; config->typec_aux_bias_pads[2].pad_auxp_dc = GPP_A19;
config->typec_aux_bias_pads[2].pad_auxn_dc = GPP_A20; config->typec_aux_bias_pads[2].pad_auxn_dc = GPP_A20;
config->TcssAuxOri = 0x10;
} }
} }