GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd: remove unused PM_ISA_CONTROL definitions 

ACPIMMIO_DECODE_REGISTER_04 is the definition in the common ACPIMMIO
code block that actually gets used. Also fix the indentation of the
ACPIMMIO register decode defines in the common code.

Change-Id: Ib2c460541be768fe05d8cc3d19a14dbd9c114a45
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48432
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
This commit is contained in:
Felix Held 2020-12-07 19:36:35 +01:00
parent 8ce68ea846
commit eb04fcbd15
3 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/soc/amd/common/block/include/amdblocks/acpimmio.h
View File

@ -16,10 +16,10 @@
* this newer method of enable in PMx04. * this newer method of enable in PMx04.
*/ */
#define ACPIMMIO_DECODE_REGISTER_24 0x24 #define ACPIMMIO_DECODE_REGISTER_24 0x24
#define PM_24_ACPIMMIO_DECODE_EN BIT(0) #define PM_24_ACPIMMIO_DECODE_EN BIT(0)
#define ACPIMMIO_DECODE_REGISTER_04 0x4 #define ACPIMMIO_DECODE_REGISTER_04 0x04
#define PM_04_BIOSRAM_DECODE_EN BIT(0) #define PM_04_BIOSRAM_DECODE_EN BIT(0)
#define PM_04_ACPIMMIO_DECODE_EN BIT(1) #define PM_04_ACPIMMIO_DECODE_EN BIT(1)

2
src/soc/amd/picasso/include/soc/southbridge.h
View File

@ -27,8 +27,6 @@
#define CF9_IO_EN BIT(1) #define CF9_IO_EN BIT(1)
#define LEGACY_IO_EN BIT(0) #define LEGACY_IO_EN BIT(0)
#define SMB_ASF_IO_BASE 0x01 /* part of PM_DECODE_EN in PPR */ #define SMB_ASF_IO_BASE 0x01 /* part of PM_DECODE_EN in PPR */
#define PM_ISA_CONTROL 0x04
#define MMIO_EN BIT(1)
#define PM_PCI_CTRL 0x08 #define PM_PCI_CTRL 0x08
#define FORCE_SLPSTATE_RETRY BIT(25) #define FORCE_SLPSTATE_RETRY BIT(25)

2
src/soc/amd/stoneyridge/include/soc/southbridge.h
View File

@ -18,8 +18,6 @@
#define PM_DECODE_EN 0x00 #define PM_DECODE_EN 0x00
#define CF9_IO_EN BIT(1) #define CF9_IO_EN BIT(1)
#define LEGACY_IO_EN BIT(0) #define LEGACY_IO_EN BIT(0)
#define PM_ISA_CONTROL 0x04
#define MMIO_EN BIT(1)
#define PM_PCI_CTRL 0x08 #define PM_PCI_CTRL 0x08
#define FORCE_SLPSTATE_RETRY BIT(25) #define FORCE_SLPSTATE_RETRY BIT(25)
#define FORCE_STPCLK_RETRY BIT(24) #define FORCE_STPCLK_RETRY BIT(24)