GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/kontron/bsl6/devicetree: Use comma separated list for arrays 

In order to improve the readability of the settings, use a comma
separated list to assign values to their indexes instead of repeating
the option name for each index.

Don't convert the settings for PCIe root ports as they should stay in
the devicetree at their related root ports.

While on it, remove superfluous comments related to modified settings.

Change-Id: I67f4fdcfb59da6c594c89d7ad3ee7f2ddbbea69b
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78592
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Felix Singer 2023-10-23 08:30:02 +02:00 committed by Felix Held
parent c4b846f22a
commit eb1a2bd132
1 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/mainboard/kontron/bsl6/devicetree.cb
View File

@ -70,20 +70,23 @@ chip soc/intel/skylake
device pci 02.0 on end # Integrated Graphics Device
device pci 08.0 on end # Gaussian Mixture Model
device pci 14.0 on # USB xHCI
register "usb2_ports[0]" = "USB2_PORT_LONG(OC0)"
register "usb2_ports[1]" = "USB2_PORT_LONG(OC0)"
register "usb2_ports[2]" = "USB2_PORT_LONG(OC1)"
register "usb2_ports[3]" = "USB2_PORT_LONG(OC1)"
register "usb2_ports[4]" = "USB2_PORT_LONG(OC2)" # Debug
register "usb2_ports" = "{
[0] = USB2_PORT_LONG(OC0),
[1] = USB2_PORT_LONG(OC0),
[2] = USB2_PORT_LONG(OC1),
[3] = USB2_PORT_LONG(OC1),
[4] = USB2_PORT_LONG(OC2), /* Debug */
}"
end
device pci 14.2 on end # Thermal Subsystem
device pci 16.0 on end # Management Engine Interface 1
device pci 17.0 on # SATA
register "SataSalpSupport" = "1"
register "SataPortsEnable[0]" = "1"
register "SataPortsEnable[1]" = "1"
register "SataPortsEnable[2]" = "1"
# SataPortsDevSlp not supported
register "SataSalpSupport" = "1"
register "SataPortsEnable" = "{
[0] = 1,
[1] = 1,
[2] = 1,
}"
end
device pci 1d.0 on # PCI Express Port 9 (COMe 0)
register "PcieRpEnable[8]" = "1"