GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/intel/adlrvp: Rename spd_info struct based on memory topology 

Naming spd_info struct based on memory topology helps in reuse of
code.
lp4_lp5_spd_info  -> memory_down_spd_info
ddr4_ddr5_spd_info -> dimm_module_spd_info

Signed-off-by: Meera Ravindranath <meera.ravindranath@intel.com>
Change-Id: I0b7a66b5524d8b80776ab7578ce7b13181af7882
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56899
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Maulik V Vaghela <maulik.v.vaghela@intel.com>
Reviewed-by: Subrata Banik <subrata.banik@intel.com>
This commit is contained in:
Meera Ravindranath 2021-08-10 20:28:49 +05:30 committed by Nick Vaccaro
parent 5142ab4193
commit eb32a85ade
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/mainboard/intel/adlrvp/romstage_fsp_params.c
View File

@ -30,12 +30,12 @@ void mainboard_memory_init_params(FSP_M_CONFIG *m_cfg)
int board_id = get_board_id(); int board_id = get_board_id();
const bool half_populated = false; const bool half_populated = false;
const struct mem_spd lp4_lp5_spd_info = { const struct mem_spd memory_down_spd_info = {
.topo = MEM_TOPO_MEMORY_DOWN, .topo = MEM_TOPO_MEMORY_DOWN,
.cbfs_index = get_spd_index(), .cbfs_index = get_spd_index(),
}; };
const struct mem_spd ddr4_ddr5_spd_info = { const struct mem_spd dimm_module_spd_info = {
.topo = MEM_TOPO_DIMM_MODULE, .topo = MEM_TOPO_DIMM_MODULE,
.smbus = { .smbus = {
[0] = { [0] = {
@ -54,7 +54,7 @@ void mainboard_memory_init_params(FSP_M_CONFIG *m_cfg)
case ADL_P_DDR4_2: case ADL_P_DDR4_2:
case ADL_P_DDR5_1: case ADL_P_DDR5_1:
case ADL_P_DDR5_2: case ADL_P_DDR5_2:
memcfg_init(m_cfg, mem_config, &ddr4_ddr5_spd_info, half_populated); memcfg_init(m_cfg, mem_config, &dimm_module_spd_info, half_populated);
break; break;
case ADL_P_LP4_1: case ADL_P_LP4_1:
case ADL_P_LP4_2: case ADL_P_LP4_2:
@ -62,7 +62,7 @@ void mainboard_memory_init_params(FSP_M_CONFIG *m_cfg)
case ADL_P_LP5_2: case ADL_P_LP5_2:
case ADL_M_LP4: case ADL_M_LP4:
case ADL_M_LP5: case ADL_M_LP5:
memcfg_init(m_cfg, mem_config, &lp4_lp5_spd_info, half_populated); memcfg_init(m_cfg, mem_config, &memory_down_spd_info, half_populated);
break; break;
default: default:
die("Unknown board id = 0x%x\n", board_id); die("Unknown board id = 0x%x\n", board_id);