GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/jecht: Correct hda_verb mic pin configs 

Commit 0148fcb4 [Combine Broadwell Chromeboxes using variant board scheme]
incorrectly flipped the mic pin configs for verb NIDs 0x18 and 0x19,
so set them back to the correct values, which match the original
Chromium sources (where the NID identifiers in the pin config comments
were reversed, which was the source of the confusion originally.

Test: build/boot guado variant, verify mic attached to 3.5mm jack functional

Change-Id: I65b813c8f801303682762ce5a7446e07af117b9f
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42518
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Matt DeVillier 2020-06-18 10:31:33 -05:00
parent e64ef9dee0
commit eb3ae1a202
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/mainboard/google/jecht/hda_verb.c
View File

@ -27,15 +27,15 @@ const u32 cim_verb_data[] = {
/* Pin Complex (NID 0x17) MONO Out - Disabled */ /* Pin Complex (NID 0x17) MONO Out - Disabled */
AZALIA_PIN_CFG(0, 0x17, 0x411111f0), AZALIA_PIN_CFG(0, 0x17, 0x411111f0),
/* Pin Complex (NID 0x18) MIC1 PORTB */ /* Pin Complex (NID 0x18) MIC1 PORTB - Disabled */
AZALIA_PIN_CFG(0, 0x18, 0x411111f0),
/* Pin Complex (NID 0x19) MIC2 PORTF */
// group 1, cap 1 // group 1, cap 1
// black, jack detect // black, jack detect
// mic in, analog // mic in, analog
// connector, left panel // connector, left panel
AZALIA_PIN_CFG(0, 0x18, 0x03a71011), AZALIA_PIN_CFG(0, 0x19, 0x03a71011),
/* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */
AZALIA_PIN_CFG(0, 0x19, 0x411111f0),
/* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ /* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */
AZALIA_PIN_CFG(0, 0x1A, 0x411111f0), AZALIA_PIN_CFG(0, 0x1A, 0x411111f0),