GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/volteer: Change VCM and EEPROM configs for ov8856 

TGL RVP and Volteer use ov8856 camera module from different vendors.
TGL RVP from Foxlink and Volteer from Sunny. ov8856 sensor is identical
for the two modules but VCM and EEPROM are different. Originally,
Volteer ACPI was set to align with Sunny module, GT9679. But it turned
out GT9679 is compatible with Foxlink's DW9768. So Volteer camera ACPI
configuration doesn't need to keep GT9679.

BUG=b:158188369
BRANCH=none
TEST=Build and boot volteer proto 2 board. Start a camera app
and check user-facing camera functionalities.

Signed-off-by: Daniel Kang <daniel.h.kang@intel.com>
Change-Id: I792608f86a59b16545dfa4edf6508de7a444bb26
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42048
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Daniel H Kang <daniel.h.kang@intel.corp-partner.google.com>
Reviewed-by: Wonkyu Kim <wonkyu.kim@intel.com>
This commit is contained in:
Daniel Kang 2020-06-03 14:02:25 -07:00 committed by Patrick Georgi
parent 51f0129ffd
commit eb43ca5fb1
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
View File

@ -331,8 +331,8 @@ Scope (\_SB.PCI0.I2C3)
Device (VCM0) Device (VCM0)
{ {
Name (_HID, "PRP0001") /* _HID: Hardware ID */ Name (_HID, "PRP0001") /* _HID: Hardware ID */
Name (_UID, 0x03) /* _UID: Unique ID */ Name (_UID, 0x00) /* _UID: Unique ID */
Name (_DDN, "GT9769 VCM") /* _DDN: DOS Device Name */ Name (_DDN, "DW9768 VCM") /* _DDN: DOS Device Name */
Method (_STA, 0, NotSerialized) /* _STA: Status */ Method (_STA, 0, NotSerialized) /* _STA: Status */
{ {
Return (0x0F) Return (0x0F)
@ -364,7 +364,7 @@ Scope (\_SB.PCI0.I2C3)
Package (0x02) Package (0x02)
{ {
"compatible", "compatible",
"giantec,gt9769-vcm" "dongwoon,dw9768"
} }
} }
}) })
@ -372,8 +372,8 @@ Scope (\_SB.PCI0.I2C3)
Device (NVM0) Device (NVM0)
{ {
Name (_HID, "PRP0001") // _HID: Hardware ID Name (_HID, "PRP0001") // _HID: Hardware ID
Name (_UID, 0x03) // _UID: Unique ID Name (_UID, 0x01) // _UID: Unique ID
Name (_DDN, "GT9769 EEPROM") // _DDN: DOS Device Name Name (_DDN, "AT24 EEPROM") // _DDN: DOS Device Name
Method (_STA, 0, NotSerialized) // _STA: Status Method (_STA, 0, NotSerialized) // _STA: Status
{ {
Return (0x0F) Return (0x0F)
@ -425,7 +425,7 @@ Scope (\_SB.PCI0.I2C3)
Package (0x02) Package (0x02)
{ {
"compatible", "compatible",
"giantec,gt9769-eeprom" "atmel,24c1024"
} }
} }
}) })