GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/fsp_baytrail: Fix use of microcode-related Kconfig variables 

SUPPORT_CPU_UCODE_IN_CBFS is a deprecated option now that all CPUs
with updateable microcode (except AGESA) load microcode from CBFS.
CPU_MICROCODE_ADDED_DURING_BUILD is a state variable that is set
based on user's choice in the microcode menu and should not be changed
directly.

Eliminate INCLUDE_MICROCODE_IN_BUILD variable, whose use directly
interferes with the microcode mechanism, remove selection of
CPU_MICROCODE_ADDED_DURING_BUILD, and do not depend
SUPPORT_CPU_UCODE_IN_CBFS on anything. This makes usage of the
microcode mechanism consistent with other CPUs in the tree.

This incorrect usage of the Kconfig variables was hiding the fact that
some of the microcode files present in fsp_baytrail/microcode_blob.c
were not present in the tree.

Change-Id: I71cb3f834c22c0363a20bd469797a9f51c215371
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-on: http://review.coreboot.org/8484
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <gaumless@gmail.com>
This commit is contained in:
Alexandru Gagniuc 2015-02-18 14:18:01 -06:00
parent 536e560d76
commit eb73a21882
4 changed files with 9 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/intel/bakersport_fsp/Kconfig
View File

@ -27,7 +27,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select HAVE_OPTION_TABLE
select OVERRIDE_MRC_CACHE_LOC
select POST_IO
select INCLUDE_MICROCODE_IN_BUILD if FSP_PACKAGE_DEFAULT
select ENABLE_BUILTIN_COM1 if FSP_PACKAGE_DEFAULT
select HAVE_FSP_BIN if FSP_PACKAGE_DEFAULT
select DEFAULT_CONSOLE_LOGLEVEL_7 if FSP_PACKAGE_DEFAULT

1
src/mainboard/intel/bayleybay_fsp/Kconfig
View File

@ -27,7 +27,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select HAVE_OPTION_TABLE
select OVERRIDE_MRC_CACHE_LOC
select POST_IO
select INCLUDE_MICROCODE_IN_BUILD if FSP_PACKAGE_DEFAULT
select ENABLE_BUILTIN_COM1 if FSP_PACKAGE_DEFAULT
select HAVE_FSP_BIN if FSP_PACKAGE_DEFAULT
select DEFAULT_CONSOLE_LOGLEVEL_7 if FSP_PACKAGE_DEFAULT

12
src/soc/intel/fsp_baytrail/Kconfig
View File

@ -47,8 +47,7 @@ config CPU_SPECIFIC_OPTIONS
select TSC_CONSTANT_RATE
select TSC_SYNC_MFENCE
select UDELAY_TSC
select SUPPORT_CPU_UCODE_IN_CBFS if INCLUDE_MICROCODE_IN_BUILD
select CPU_MICROCODE_ADDED_DURING_BUILD if INCLUDE_MICROCODE_IN_BUILD
select SUPPORT_CPU_UCODE_IN_CBFS
select ROMSTAGE_RTC_INIT
config BOOTBLOCK_CPU_INIT
@ -84,15 +83,6 @@ config VGA_BIOS_ID
This is the default PCI ID for the Bay Trail graphics
devices. This string names the vbios ROM in cbfs.
config INCLUDE_MICROCODE_IN_BUILD
bool "Build in microcode patch"
default n
help
Enable if the microcode patch is available. For the
BayTrail - I processors, the filename should start with
"M01". Using a microcode patch for the incorrect BayTrail
SKU will lead to unpredictable results.
config MICROCODE_INCLUDE_PATH
string "Microcode Include path"
default "../intel/cpu/baytrail/microcode"

8
src/soc/intel/fsp_baytrail/microcode/microcode_blob.c
View File

@ -19,11 +19,19 @@
unsigned microcode[] = {
/*
* The problem is that these microcode files are not in the tree. They come
* with FSP, so let the user deal with the include paths when HAVE_FSP_BIN
* is enabled.
*/
#if IS_ENABLED(CONFIG_HAVE_FSP_BIN)
/* Region size is 0x30000 - update in microcode_size.h if it gets larger. */
#include "M0230672228.h" // M0230672: Baytrail "Super SKU" B0/B1
#include "M0130673322.h" // M0130673: Baytrail I B2 / B3
#include "M0130679901.h" // M0130679: Baytrail I D0
#endif
/* Dummy terminator */
0x0, 0x0, 0x0, 0x0,
0x0, 0x0, 0x0, 0x0,