GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/kahlee: Set stapm parameters with time value fixed 

stapm_time passed to smu via agesa is in msec. With earlier value
smu was getting stapm_time as 2.5 sec instead of 2500 sec and thus
causing issue in S3, and audio in PsppBalanceLow state.

BUG=b:117569918, b:117252463
TEST=
1.) audio works with PsppBalanceLow
2.) S3 cycles

Change-Id: I673e7e673d042918dff47141f37bbca354f5c45c
Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com>
Reviewed-on: https://review.coreboot.org/29027
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-by: Marc Jones <marc@marcjonesconsulting.com>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
This commit is contained in:
Akshu Agrawal 2018-10-11 15:31:40 +05:30 committed by Martin Roth
parent 83bd46e5e5
commit eb75f7c360
2 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/mainboard/google/kahlee/variants/careena/devicetree.cb
View File

@ -20,11 +20,9 @@ chip soc/amd/stoneyridge
register "dram_clear_on_reset" = "DRAM_CONTENTS_KEEP"
register "uma_mode" = "UMAMODE_SPECIFIED_SIZE"
register "uma_size" = "32 * MiB"
# Don't set STAPM values for now
# register "stapm_percent" = "68"
# register "stapm_time" = "2500"
# register "stapm_power" = "7800"
register "stapm_percent" = "68"
register "stapm_time" = "2500000"
register "stapm_power" = "7800"
# Enable I2C0 for audio, USB3 hub at 400kHz
register "i2c[0]" = "{

8
src/mainboard/google/kahlee/variants/grunt/devicetree.cb
View File

@ -20,11 +20,9 @@ chip soc/amd/stoneyridge
register "dram_clear_on_reset" = "DRAM_CONTENTS_KEEP"
register "uma_mode" = "UMAMODE_SPECIFIED_SIZE"
register "uma_size" = "32 * MiB"
# For now, don't set STAPM values
# register "stapm_percent" = "80"
# register "stapm_time" = "2500"
# register "stapm_power" = "7800"
register "stapm_percent" = "80"
register "stapm_time" = "2500000"
register "stapm_power" = "7800"
# Enable I2C0 for audio, USB3 hub at 400kHz
register "i2c[0]" = "{