GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Doc/*/gerrit_guidelines.md: Expand fast-track rule 

Commits that fix a recently-introduced regression can be submitted early
to minimise the impact of said regression. However, it is important that
the commit message properly reflects what is being fixed and what commit
introduced the issue.

Change-Id: Ifd49582ae1cbcfe6ee3816e0658dbd0432801161
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63780
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Angel Pons 2022-04-22 11:29:46 +02:00 committed by Felix Held
parent 56fa67c151
commit eca8859133
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Documentation/contributing/gerrit_guidelines.md
View File

@ -53,7 +53,10 @@ it's implemented, should restart the wait period.
a recently-introduced issue (build, boot or OS-level compatibility, not a recently-introduced issue (build, boot or OS-level compatibility, not
necessarily identified by coreboot.org facilities). Its commit message necessarily identified by coreboot.org facilities). Its commit message
has to explain what change introduced the problem and the nature of has to explain what change introduced the problem and the nature of
the problem so that the emergency need becomes apparent. The change the problem so that the emergency need becomes apparent. Avoid stating
something like "fix build error" in the commit summary, describe what
the commit does instead, just like any other commit. In addition, it is
recommended to reference the commit that introduced the issue. The change
itself should be as limited in scope and impact as possible to make it itself should be as limited in scope and impact as possible to make it
simple to assess the impact. Such a change can be merged early with 3 simple to assess the impact. Such a change can be merged early with 3
Code-Review+2. For emergency fixes that affect a single project (SoC, Code-Review+2. For emergency fixes that affect a single project (SoC,