GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/parrot/smihandler: Use new PMBASE API 

Change-Id: Ie95d9c04375e0125bae9bc01ae5caef423faf33e
Signed-off-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-on: https://review.coreboot.org/27679
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
Patrick Rudolph 2018-07-28 12:47:42 +02:00 committed by Patrick Georgi
parent 5d3707bbc3
commit ecb2399ab8
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/mainboard/google/parrot/smihandler.c
View File

@ -20,6 +20,7 @@
#include <southbridge/intel/bd82x6x/pch.h> #include <southbridge/intel/bd82x6x/pch.h>
#include <southbridge/intel/bd82x6x/me.h> #include <southbridge/intel/bd82x6x/me.h>
#include <southbridge/intel/common/pmutil.h> #include <southbridge/intel/common/pmutil.h>
#include <southbridge/intel/common/pmbase.h>
#include <northbridge/intel/sandybridge/sandybridge.h> #include <northbridge/intel/sandybridge/sandybridge.h>
#include <cpu/intel/model_206ax/model_206ax.h> #include <cpu/intel/model_206ax/model_206ax.h>
#include <elog.h> #include <elog.h>
@ -29,7 +30,6 @@
static u8 mainboard_smi_ec(void) static u8 mainboard_smi_ec(void)
{ {
u8 src; u8 src;
u32 pm1_cnt;
#if IS_ENABLED(CONFIG_ELOG_GSMI) #if IS_ENABLED(CONFIG_ELOG_GSMI)
static int battery_critical_logged; static int battery_critical_logged;
#endif #endif
@ -54,9 +54,7 @@ static u8 mainboard_smi_ec(void)
elog_add_event_byte(ELOG_TYPE_EC_EVENT, EC_EVENT_LID_CLOSED); elog_add_event_byte(ELOG_TYPE_EC_EVENT, EC_EVENT_LID_CLOSED);
#endif #endif
/* Go to S5 */ /* Go to S5 */
pm1_cnt = inl(smm_get_pmbase() + PM1_CNT); write_pmbase32(PM1_CNT, read_pmbase32(PM1_CNT) | (0xf << 10));
pm1_cnt |= (0xf << 10);
outl(pm1_cnt, smm_get_pmbase() + PM1_CNT);
break; break;
} }
@ -65,8 +63,6 @@ static u8 mainboard_smi_ec(void)
void mainboard_smi_gpi(u32 gpi_sts) void mainboard_smi_gpi(u32 gpi_sts)
{ {
u32 pm1_cnt;
printk(BIOS_DEBUG, "mainboard_smi_gpi: %x\n", gpi_sts); printk(BIOS_DEBUG, "mainboard_smi_gpi: %x\n", gpi_sts);
if (gpi_sts & (1 << EC_SMI_GPI)) { if (gpi_sts & (1 << EC_SMI_GPI)) {
/* Process all pending events from EC */ /* Process all pending events from EC */
@ -79,9 +75,7 @@ void mainboard_smi_gpi(u32 gpi_sts)
elog_add_event_byte(ELOG_TYPE_EC_EVENT, EC_EVENT_LID_CLOSED); elog_add_event_byte(ELOG_TYPE_EC_EVENT, EC_EVENT_LID_CLOSED);
#endif #endif
/* Go to S5 */ /* Go to S5 */
pm1_cnt = inl(smm_get_pmbase() + PM1_CNT); write_pmbase32(PM1_CNT, read_pmbase32(PM1_CNT) | (0xf << 10));
pm1_cnt |= (0xf << 10);
outl(pm1_cnt, smm_get_pmbase() + PM1_CNT);
} }
} }