From ecb2a84690e8c90d02ab3de8dcf4f250049dfee8 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Wed, 19 Jul 2023 19:19:41 +0530 Subject: [PATCH] mb/google/rex: Create a `rex` model for easier variant integration MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch creates  a rex model so that other variants developed using `rex` baseboard are easy to land without duplicating the config selection. So far, `rex0` and `rex_ec_ish` are developed using the `rex` model. The plan is to extend the support for `rex4es` and `rex4es_ec_ish` variants. TEST=Able to build and boot google/rex. Change-Id: Id4e8d1162da93b7266ee1108f870e89b6d884ab9 Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/76608 Reviewed-by: Eric Lai Reviewed-by: Jakub Czapiga Tested-by: build bot (Jenkins) Reviewed-by: Kapil Porwal --- src/mainboard/google/rex/Kconfig | 10 ++++++++++ src/mainboard/google/rex/Kconfig.name | 16 ++-------------- 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/src/mainboard/google/rex/Kconfig b/src/mainboard/google/rex/Kconfig index 014c3a7974..9c755085ba 100644 --- a/src/mainboard/google/rex/Kconfig +++ b/src/mainboard/google/rex/Kconfig @@ -44,6 +44,16 @@ config BOARD_GOOGLE_BASEBOARD_REX select SYSTEM_TYPE_LAPTOP select TPM_GOOGLE_TI50 +config BOARD_GOOGLE_MODEL_REX + def_bool n + select BOARD_GOOGLE_BASEBOARD_REX + select DRIVERS_GENERIC_MAX98357A + select DRIVERS_GENESYSLOGIC_GL9755 + select DRIVERS_INTEL_ISH + select DRIVERS_INTEL_SOUNDWIRE + select DRIVERS_SOUNDWIRE_CS42L42 + select DRIVERS_SOUNDWIRE_MAX98363 + config BOARD_GOOGLE_BASEBOARD_OVIS def_bool n select BOARD_GOOGLE_REX_COMMON diff --git a/src/mainboard/google/rex/Kconfig.name b/src/mainboard/google/rex/Kconfig.name index 8084a045bd..94ae1a059f 100644 --- a/src/mainboard/google/rex/Kconfig.name +++ b/src/mainboard/google/rex/Kconfig.name @@ -2,13 +2,7 @@ comment "Rex" config BOARD_GOOGLE_REX0 bool "-> Rex 0" - select BOARD_GOOGLE_BASEBOARD_REX - select DRIVERS_GENERIC_MAX98357A - select DRIVERS_GENESYSLOGIC_GL9755 - select DRIVERS_INTEL_ISH - select DRIVERS_INTEL_SOUNDWIRE - select DRIVERS_SOUNDWIRE_CS42L42 - select DRIVERS_SOUNDWIRE_MAX98363 + select BOARD_GOOGLE_MODEL_REX config BOARD_GOOGLE_SCREEBO bool "-> Screebo" @@ -21,13 +15,7 @@ config BOARD_GOOGLE_KARIS config BOARD_GOOGLE_REX_EC_ISH bool "-> Rex EC ISH" - select BOARD_GOOGLE_BASEBOARD_REX - select DRIVERS_GENERIC_MAX98357A - select DRIVERS_GENESYSLOGIC_GL9755 - select DRIVERS_INTEL_ISH - select DRIVERS_INTEL_SOUNDWIRE - select DRIVERS_SOUNDWIRE_CS42L42 - select DRIVERS_SOUNDWIRE_MAX98363 + select BOARD_GOOGLE_MODEL_REX config BOARD_GOOGLE_OVIS bool "-> Ovis"