From edf1ffef9f371c48c86ba219806dd053e7b7212e Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Thu, 25 May 2023 16:59:23 +0100 Subject: [PATCH] mainboard/starlabs/*: Remove the power_on_after_fail option None of these boards have an RTC battery, so this option has no effect. Remove it. Signed-off-by: Sean Rhodes Change-Id: I9a55227f74c0b9ae9b56bdef4b8f53b2425b331c Reviewed-on: https://review.coreboot.org/c/coreboot/+/75450 Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai --- src/mainboard/starlabs/lite/cmos.default | 2 -- src/mainboard/starlabs/lite/cmos.layout | 3 --- src/mainboard/starlabs/lite/variants/glkr/cmos.default | 2 -- src/mainboard/starlabs/lite/variants/glkr/cmos.layout | 3 --- src/mainboard/starlabs/starbook/cmos.default | 2 -- src/mainboard/starlabs/starbook/cmos.layout | 3 --- src/mainboard/starlabs/starbook/variants/tgl/cmos.default | 2 -- src/mainboard/starlabs/starbook/variants/tgl/cmos.layout | 3 --- 8 files changed, 20 deletions(-) diff --git a/src/mainboard/starlabs/lite/cmos.default b/src/mainboard/starlabs/lite/cmos.default index c59bbe549c..d8a7cd104d 100644 --- a/src/mainboard/starlabs/lite/cmos.default +++ b/src/mainboard/starlabs/lite/cmos.default @@ -13,8 +13,6 @@ legacy_8254_timer=Disable kbl_timeout=30 seconds fn_ctrl_swap=Disable mirror_flag=Disable -# southbridge -power_on_after_fail=Disable # Functions fn_lock_state=0x1 trackpad_state=0x1 diff --git a/src/mainboard/starlabs/lite/cmos.layout b/src/mainboard/starlabs/lite/cmos.layout index 71dd3902f6..d594c76955 100644 --- a/src/mainboard/starlabs/lite/cmos.layout +++ b/src/mainboard/starlabs/lite/cmos.layout @@ -31,9 +31,6 @@ entries 616 1 e 1 mirror_flag 624 4 h 0 mirror_flag_counter -# coreboot config options: southbridge -800 2 e 6 power_on_after_fail - # coreboot config options: check sums 984 16 h 0 check_sum diff --git a/src/mainboard/starlabs/lite/variants/glkr/cmos.default b/src/mainboard/starlabs/lite/variants/glkr/cmos.default index 3dbe92d5d0..1499ead26f 100644 --- a/src/mainboard/starlabs/lite/variants/glkr/cmos.default +++ b/src/mainboard/starlabs/lite/variants/glkr/cmos.default @@ -14,8 +14,6 @@ kbl_timeout=30 seconds fn_ctrl_swap=Disable fast_charge=Normal mirror_flag=Disable -# southbridge -power_on_after_fail=Disable # Functions fn_lock_state=0x1 trackpad_state=0x1 diff --git a/src/mainboard/starlabs/lite/variants/glkr/cmos.layout b/src/mainboard/starlabs/lite/variants/glkr/cmos.layout index d53116c80b..8fa57253ec 100644 --- a/src/mainboard/starlabs/lite/variants/glkr/cmos.layout +++ b/src/mainboard/starlabs/lite/variants/glkr/cmos.layout @@ -32,9 +32,6 @@ entries 624 1 e 1 mirror_flag 632 4 h 0 mirror_flag_counter -# coreboot config options: southbridge -800 2 e 6 power_on_after_fail - # coreboot config options: check sums 984 16 h 0 check_sum diff --git a/src/mainboard/starlabs/starbook/cmos.default b/src/mainboard/starlabs/starbook/cmos.default index 18abc93004..75b722d5bd 100644 --- a/src/mainboard/starlabs/starbook/cmos.default +++ b/src/mainboard/starlabs/starbook/cmos.default @@ -17,8 +17,6 @@ pci_hot_plug=Disable kbl_timeout=30 seconds fn_ctrl_swap=Disable mirror_flag=Disable -# southbridge -power_on_after_fail=Disable # Functions fn_lock_state=0x1 trackpad_state=0x1 diff --git a/src/mainboard/starlabs/starbook/cmos.layout b/src/mainboard/starlabs/starbook/cmos.layout index c15c6f8347..f534630566 100644 --- a/src/mainboard/starlabs/starbook/cmos.layout +++ b/src/mainboard/starlabs/starbook/cmos.layout @@ -41,9 +41,6 @@ entries 632 1 e 1 mirror_flag 640 4 h 0 mirror_flag_counter -# coreboot config options: southbridge -800 2 e 6 power_on_after_fail - # coreboot config options: check sums 984 16 h 0 check_sum diff --git a/src/mainboard/starlabs/starbook/variants/tgl/cmos.default b/src/mainboard/starlabs/starbook/variants/tgl/cmos.default index cca64feeab..dc789b900b 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/cmos.default +++ b/src/mainboard/starlabs/starbook/variants/tgl/cmos.default @@ -17,8 +17,6 @@ thunderbolt=Disable kbl_timeout=30 seconds fn_ctrl_swap=Disable mirror_flag=Disable -# southbridge -power_on_after_fail=Disable # Functions fn_lock_state=0x1 trackpad_state=0x1 diff --git a/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout b/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout index b5a2fb7891..aed755c2bc 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout +++ b/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout @@ -41,9 +41,6 @@ entries 632 1 e 1 mirror_flag 640 4 h 0 mirror_flag_counter -# coreboot config options: southbridge -800 2 e 6 power_on_after_fail - # coreboot config options: check sums 984 16 h 0 check_sum