From eebf63c0c3a07e5ba476db54c6e015b0143a0d13 Mon Sep 17 00:00:00 2001 From: Dtrain Hsu Date: Tue, 27 Jun 2023 10:50:51 +0800 Subject: [PATCH] mb/google/nissa/var/uldren: Update DPTF parameters and tcc_offset Follow the Project_Uldren_Thermal_paramters_list_2023_0626.xlsx to modify DPTF parameters and tcc_offset. - Set tcc_offset to 3. - Update Critical Policy trip point. - Update Power Limits PL1 minimum step size to control limits (in mW). BUG=b:282598257 BRANCH=firmware-nissa-15217.B TEST=boot uldren to ChromeOS and pass thermal test. Change-Id: Ic5bbb3aa3b036a1eae8a95f63b570db2dc6da978 Signed-off-by: Dtrain Hsu Reviewed-on: https://review.coreboot.org/c/coreboot/+/76105 Reviewed-by: Sumeet R Pawnikar Reviewed-by: Eric Lai Tested-by: build bot (Jenkins) Reviewed-by: Paul Yang Reviewed-by: Ivan Chen Reviewed-by: Derek Huang --- .../google/brya/variants/uldren/overridetree.cb | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/mainboard/google/brya/variants/uldren/overridetree.cb b/src/mainboard/google/brya/variants/uldren/overridetree.cb index a873a6288b..973a6de202 100644 --- a/src/mainboard/google/brya/variants/uldren/overridetree.cb +++ b/src/mainboard/google/brya/variants/uldren/overridetree.cb @@ -106,6 +106,8 @@ chip soc/intel/alderlake .vnn_icc_max_ma = 500, }" + register "tcc_offset" = "3" + # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value | @@ -175,10 +177,10 @@ chip soc/intel/alderlake }" ## Critical Policy register "policies.critical" = "{ - [0] = DPTF_CRITICAL(CPU, 105, SHUTDOWN), - [1] = DPTF_CRITICAL(TEMP_SENSOR_0, 98, SHUTDOWN), - [2] = DPTF_CRITICAL(TEMP_SENSOR_1, 98, SHUTDOWN), - [3] = DPTF_CRITICAL(TEMP_SENSOR_2, 98, SHUTDOWN), + [0] = DPTF_CRITICAL(CPU, 130, SHUTDOWN), + [1] = DPTF_CRITICAL(TEMP_SENSOR_0, 105, SHUTDOWN), + [2] = DPTF_CRITICAL(TEMP_SENSOR_1, 105, SHUTDOWN), + [3] = DPTF_CRITICAL(TEMP_SENSOR_2, 105, SHUTDOWN), }" register "controls.power_limits" = "{ @@ -187,7 +189,7 @@ chip soc/intel/alderlake .max_power = 6000, .time_window_min = 28 * MSECS_PER_SEC, .time_window_max = 28 * MSECS_PER_SEC, - .granularity = 250 + .granularity = 125 }, .pl2 = { .min_power = 25000,