Small coding style fixes and documentation updates (trivial).

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>



git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3121 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
This commit is contained in:
Uwe Hermann 2008-03-01 18:49:39 +00:00
parent a04027efca
commit eec5ff4ccb
5 changed files with 14 additions and 12 deletions

View File

@ -30,10 +30,10 @@ Installation
Usage
-----
$ superiotool [-d] [-l] [-V] [-v] [-h]
$ superiotool [-d] [-e] [-l] [-V] [-v] [-h]
-d | --dump Dump Super I/O register contents
-e | --extra-dump Dump Secondary registers too (like EC registers etc.)
-e | --extra-dump Dump secondary registers too (e.g. EC registers)
-l | --list-supported Show the list of supported Super I/O chips
-V | --verbose Verbose mode
-v | --version Show the superiotool version

View File

@ -379,7 +379,7 @@ static void exit_conf_mode_ite(uint16_t port)
static void probe_idregs_ite_helper(const char *init, uint16_t port)
{
uint16_t id, chipver;
uint16_t id, chipver, ecport;
probing_for("ITE", init, port);
@ -400,13 +400,16 @@ static void probe_idregs_ite_helper(const char *init, uint16_t port)
dump_superio("ITE", reg_table, port, id);
if (extra_dump) {
uint16_t ecport;
regwrite(port, 0x07, 0x04); /*EC LDN*/
regwrite(port, 0x07, 0x04); /* Select LDN 4 (EC). */
/* Get EC base address (stored in LDN 4, index 0x60/0x61). */
ecport = regval(port, 0x60) << 8;
ecport |= regval(port, 0x61);
/* EC address register = EC base address + 5. */
ecport += 5;
printf("Environment Controller (0x%04x)\n",ecport);
printf("Environment controller (0x%04x)\n", ecport);
dump_superio("ITE-EC", ec_table, ecport, id);
}
}

View File

@ -77,8 +77,8 @@ detailed information about the
Dump extra secondary register contents too, if available. Only in combination
with the
.B --dump
option. This option will, for instance, dump the Environmental Controller
configuration registers for the ITE IT8716f chip. The format is similar to
option. This option will, for instance, dump the environmental controller (EC)
configuration registers for the ITE IT8716F chip. The format is similar to
the output of the
.B --dump
option.

View File

@ -158,8 +158,7 @@ void probing_for(const char *vendor, const char *info, uint16_t port)
return;
/* Yes, there's no space between '%s' and 'at'! */
printf("Probing for %s Super I/O %sat 0x%x...\n",
vendor, info, port);
printf("Probing for %s Super I/O %sat 0x%x...\n", vendor, info, port);
}
/** Print a list of all supported chips from the given vendor. */

View File

@ -30,9 +30,9 @@
#include <getopt.h>
#include <sys/io.h>
#define USAGE "Usage: superiotool [-d] [-l] [-V] [-v] [-h]\n\n\
#define USAGE "Usage: superiotool [-d] [-e] [-l] [-V] [-v] [-h]\n\n\
-d | --dump Dump Super I/O register contents\n\
-e | --extra-dump Dump Secondary registers too (like EC registers etc.)\n\
-e | --extra-dump Dump secondary registers too (e.g. EC registers)\n\
-l | --list-supported Show the list of supported Super I/O chips\n\
-V | --verbose Verbose mode\n\
-v | --version Show the superiotool version\n\