From ef886f3034e7086795c387b156bc92831ada94e8 Mon Sep 17 00:00:00 2001 From: Tim Wawrzynczak Date: Tue, 28 Jun 2022 12:12:48 -0600 Subject: [PATCH] mb/google/brya/acpi/peg: Fix Power Resource _ON and _OFF The _ON and _OFF methods for the root port's power resource were calling the _ON and _OFF in the PEGP namespace, which was the incorrect method, it should have been NPON/NPOF, so this patch updates that. BUG=b:236676400 Signed-off-by: Tim Wawrzynczak Change-Id: Ia3653996329473f133e3f0d53306882dc3213b6b Reviewed-on: https://review.coreboot.org/c/coreboot/+/65487 Reviewed-by: Eric Lai Reviewed-by: Ivy Jian Reviewed-by: Subrata Banik Tested-by: build bot (Jenkins) --- src/mainboard/google/brya/acpi/peg.asl | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/mainboard/google/brya/acpi/peg.asl b/src/mainboard/google/brya/acpi/peg.asl index 55551bc714..e804c78e3b 100644 --- a/src/mainboard/google/brya/acpi/peg.asl +++ b/src/mainboard/google/brya/acpi/peg.asl @@ -1,8 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ -External (\_SB.PCI0.DGPU, DeviceObj) -External (\_SB.PCI0.PEG0.PEGP._OFF, MethodObj) -External (\_SB.PCI0.PEG0.PEGP._ON, MethodObj) +External (\_SB.PCI0.PEG0.PEGP.NPON, MethodObj) +External (\_SB.PCI0.PEG0.PEGP.NPOF, MethodObj) OperationRegion (PCIC, PCI_Config, 0x00, 0x100) Field (PCIC, AnyAcc, NoLock, Preserve) @@ -78,14 +77,14 @@ PowerResource (PGPR, 0, 0) Method (_ON, 0, Serialized) { /* Power up GPU from GCOFF (or GC6 exit if deferred) */ - \_SB.PCI0.PEG0.PEGP._ON () + \_SB.PCI0.PEG0.PEGP.NPON () _STA = 1 } Method (_OFF, 0, Serialized) { /* Power down GPU to GCOFF (or GC6 entry if deferred) */ _STA = 0 - \_SB.PCI0.PEG0.PEGP._OFF () + \_SB.PCI0.PEG0.PEGP.NPOF () } Name (_STA, 0) }