From efc0fa09fe47f5c57dfb4f912feb53b0e2dca192 Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Tue, 25 Jul 2017 12:12:29 +0200 Subject: [PATCH] soc/intel/skylake/chip.h: Provide enum values for SataMode The values were verified to be correct with the KabylakeFsp0001 from github. Skylake FSP documentation disagrees so YMMV. Change-Id: I1ee04dbbed48d5376dbc24ae70753b059f2646eb Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/20765 Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin --- src/soc/intel/skylake/chip.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/soc/intel/skylake/chip.h b/src/soc/intel/skylake/chip.h index 1377237672..efd3566f76 100644 --- a/src/soc/intel/skylake/chip.h +++ b/src/soc/intel/skylake/chip.h @@ -138,7 +138,13 @@ struct soc_intel_skylake_config { /* SATA related */ u8 EnableSata; - u8 SataMode; + enum { + /* Documentation and header files of Skylake FSP disagree on + the values, Kaby Lake FSP (KabylakeFsp0001 on github) uses + these: */ + KBLFSP_SATA_MODE_AHCI = 0, + KBLFSP_SATA_MODE_RAID = 1, + } SataMode; u8 SataSalpSupport; u8 SataPortsEnable[8]; u8 SataPortsDevSlp[8];