From f0286047189cd1a116486ec57284cbdfeafe7a3a Mon Sep 17 00:00:00 2001 From: Julius Werner Date: Tue, 9 Apr 2019 15:57:07 -0700 Subject: [PATCH] kconfig_lint: Make uses of CONFIG() on an unknown option an error This check had very few false positives which were all easily resolved, and it's unlikely that further false positives will become problematic in the future. On the other hand, it does detect a very severe bug (when you think you're using a Kconfig but you aren't due to a typo), so since warnings are currently not very visible, let's turn this into an error because the pros clearly outweigh the cons for that. Change-Id: I897b5e13d3242fb77b69f0bd3585baa7476aa726 Signed-off-by: Julius Werner Reviewed-on: https://review.coreboot.org/c/coreboot/+/32257 Reviewed-by: Furquan Shaikh Reviewed-by: Paul Menzel Reviewed-by: Nico Huber Tested-by: build bot (Jenkins) --- util/lint/kconfig_lint | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint index 4d0a755efb..502a61878b 100755 --- a/util/lint/kconfig_lint +++ b/util/lint/kconfig_lint @@ -47,7 +47,7 @@ my $warnings_found = 0; my $exclude_dirs_and_files = '^build/\|^coreboot-builds/\|^configs/\|^util/\|^\.git/\|^payloads\|^Documentation\|^3rdparty' . '\|' . # directories to exclude when searching for used symbols - '\.config\|\.txt$\|\.tex$\|\.tags'; #files to exclude when looking for symbols + '\.config\|\.txt$\|\.tex$\|\.tags\|/kconfig.h'; #files to exclude when looking for symbols my $payload_files_to_check='payloads/Makefile.inc payloads/external/Makefile.inc'; my $config_file = ""; # name of config file to load symbol values from. my @wholeconfig; # document the entire kconfig structure @@ -314,7 +314,7 @@ sub check_is_enabled { } } else { - show_warning("CONFIG() used on unknown value ($symbol) at $file:$lineno."); + show_error("CONFIG() used on unknown value ($symbol) at $file:$lineno."); } } } elsif ( $line =~ /^([^:]+):(\d+):(.+IS_ENABLED.*)/ ) {