GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/lenovo/t430: Remove superfluous comments related to PCI devices 

Since all devicetrees from lenovo/t430 are using the reference names for
PCI devices now, remove the equivalent comments documenting their
function.

Change-Id: I84f432e89c41a02115715f7f1b56123dd0d81171
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79942
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <patrick.rudolph@9elements.com>
This commit is contained in:
Felix Singer 2024-01-13 22:41:27 +01:00 committed by Felix Singer
parent 5e1bfee664
commit f02e9e87b4
3 changed files with 33 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
src/mainboard/lenovo/t430s/devicetree.cb
View File

@ -17,9 +17,9 @@ chip northbridge/intel/sandybridge
device domain 0 on device domain 0 on
subsystemid 0x17aa 0x21fb inherit subsystemid 0x17aa 0x21fb inherit
device ref host_bridge on end # host bridge device ref host_bridge on end
device ref peg10 on end # PCIe Bridge for discrete graphics device ref peg10 on end # Discrete graphics
device ref igd on end # Integrated Graphics Controller device ref igd on end
chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH
# GPI routing # GPI routing
@ -52,28 +52,28 @@ chip northbridge/intel/sandybridge
register "spi_uvscc" = "0x2005" register "spi_uvscc" = "0x2005"
register "spi_lvscc" = "0x2005" register "spi_lvscc" = "0x2005"
device ref xhci on end # USB 3.0 Controller device ref xhci on end
device ref mei1 on end # Management Engine Interface 1 device ref mei1 on end
device ref mei2 off end # Management Engine Interface 2 device ref mei2 off end
device ref me_ide_r off end # Management Engine IDE-R device ref me_ide_r off end
device ref me_kt off end # Management Engine KT device ref me_kt off end
device ref gbe on device ref gbe on
subsystemid 0x17aa 0x21f3 subsystemid 0x17aa 0x21f3
end # Intel Gigabit Ethernet end
device ref ehci2 on end # USB Enhanced Host Controller #2 device ref ehci2 on end
device ref hda on end # High Definition Audio Controller device ref hda on end
device ref pcie_rp1 off end # PCIe Port #1 device ref pcie_rp1 off end
device ref pcie_rp2 on end # PCIe Port #2 Integrated Wireless LAN device ref pcie_rp2 on end # Integrated Wireless LAN
device ref pcie_rp3 on device ref pcie_rp3 on
smbios_slot_desc "7" "3" "ExpressCard Slot" "8" smbios_slot_desc "7" "3" "ExpressCard Slot" "8"
end # PCIe Port #3 ExpressCard end
device ref pcie_rp4 off end # PCIe Port #4 device ref pcie_rp4 off end
device ref pcie_rp5 off end # PCIe Port #5 device ref pcie_rp5 off end
device ref pcie_rp6 off end # PCIe Port #6 Intel Gigabit Ethernet PHY (not PCIe) device ref pcie_rp6 off end
device ref pcie_rp7 off end # PCIe Port #7 device ref pcie_rp7 off end
device ref pcie_rp8 off end # PCIe Port #8 device ref pcie_rp8 off end
device ref ehci1 on end # USB Enhanced Host Controller #1 device ref ehci1 on end
device ref pci_bridge off end # PCI bridge device ref pci_bridge off end
device ref lpc on device ref lpc on
chip ec/lenovo/pmh7 chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy device pnp ff.1 on end # dummy
@ -117,8 +117,8 @@ chip northbridge/intel/sandybridge
register "eventd_enable" = "0xff" register "eventd_enable" = "0xff"
register "evente_enable" = "0x0d" register "evente_enable" = "0x0d"
end end
end # LPC Controller end
device ref sata1 on end # 6 port SATA AHCI Controller device ref sata1 on end
device ref smbus on device ref smbus on
# eeprom, 8 virtual devices, same chip # eeprom, 8 virtual devices, same chip
chip drivers/i2c/at24rf08c chip drivers/i2c/at24rf08c
@ -131,9 +131,9 @@ chip northbridge/intel/sandybridge
device i2c 5e on end device i2c 5e on end
device i2c 5f on end device i2c 5f on end
end end
end # SMBus Controller end
device ref sata2 off end # SATA Controller 2 device ref sata2 off end
device ref thermal on end # Thermal device ref thermal on end
end end
end end
end end

4
src/mainboard/lenovo/t430s/variants/t430s/overridetree.cb
View File

@ -4,7 +4,7 @@ chip northbridge/intel/sandybridge
chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH
# Enable hotplug on Port 5 for Thunderbolt controller # Enable hotplug on Port 5 for Thunderbolt controller
register "pcie_hotplug_map" = "{ 0, 0, 1, 0, 1, 0, 0, 0 }" register "pcie_hotplug_map" = "{ 0, 0, 1, 0, 1, 0, 0, 0 }"
device ref pcie_rp5 on end # PCIe Port #5 Thunderbolt controller device ref pcie_rp5 on end # Thunderbolt controller
device ref lpc on device ref lpc on
chip ec/lenovo/h8 chip ec/lenovo/h8
device pnp ff.2 on end # dummy device pnp ff.2 on end # dummy
@ -12,7 +12,7 @@ chip northbridge/intel/sandybridge
register "bdc_gpio_num" = "54" register "bdc_gpio_num" = "54"
register "bdc_gpio_lvl" = "0" register "bdc_gpio_lvl" = "0"
end end
end # LPC Controller end
end end
end end
end end

10
src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb
View File

@ -15,7 +15,7 @@ chip northbridge/intel/sandybridge
device domain 0 on device domain 0 on
subsystemid 0x17aa 0x2208 inherit subsystemid 0x17aa 0x2208 inherit
device ref peg10 off end # PCIe Bridge for discrete graphics device ref peg10 off end # discrete graphics
chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH
# Enable SATA ports 0 (HDD bay) & 1 (WWAN M.2 SATA) & 4 (dock) # Enable SATA ports 0 (HDD bay) & 1 (WWAN M.2 SATA) & 4 (dock)
@ -23,14 +23,14 @@ chip northbridge/intel/sandybridge
# T431s has no Express Card slot. # T431s has no Express Card slot.
register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }" register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }"
device ref pcie_rp1 on # PCIe Port #1 device ref pcie_rp1 on
chip drivers/ricoh/rce822 # Ricoh cardreader chip drivers/ricoh/rce822 # Ricoh cardreader
register "disable_mask" = "0x87" register "disable_mask" = "0x87"
register "sdwppol" = "0" register "sdwppol" = "0"
device pci 00.0 on end # Ricoh SD card reader device pci 00.0 on end # Ricoh SD card reader
end end
end end
device ref pcie_rp3 off end # PCIe Port #3 device ref pcie_rp3 off end
device ref lpc on device ref lpc on
chip ec/lenovo/h8 chip ec/lenovo/h8
device pnp ff.2 on end # dummy device pnp ff.2 on end # dummy
@ -41,8 +41,8 @@ chip northbridge/intel/sandybridge
# T431s only has BT on wlan card # T431s only has BT on wlan card
register "has_bdc_detection" = "0" register "has_bdc_detection" = "0"
end end
end # LPC Controller end
device ref thermal off end # Thermal device ref thermal off end
end end
end end
end end