GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

exynos5420: Don't map low addresses that lead nowhere 

I just spent half a day (including the time to implement a stack dumper)
to figure out that I am reading from a NULL pointer. A problem this
simple should be more easy to catch. Let's mark the address range below
SRAM as uncached so that the MMU can yell at you right away for being
the bad programmer you are when you access a NULL pointer.

Change-Id: I4a3a13f75bf21b25732be2ecb69d47503eff1b53
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/170112
Reviewed-by: Ronald Minnich <rminnich@chromium.org>
(cherry picked from commit 7316732ea0ccdc0d607bde81dbb38ca9abd29fa9)
Signed-off-by: Isaac Christensen <isaac.christensen@se-eng.com>
Reviewed-on: http://review.coreboot.org/6650
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
This commit is contained in:
Julius Werner 2013-09-19 20:15:45 -07:00 committed by Isaac Christensen
parent 12b121f3fe
commit f0cd03c142
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/cpu/samsung/exynos5420/bootblock.c
View File

@ -24,7 +24,7 @@
#include "cpu.h" #include "cpu.h"
/* convenient shorthand (in MB) */ /* convenient shorthand (in MB) */
#define SRAM_START (0x02020000 >> 20) #define SRAM_START (EXYNOS5_SRAM_BASE >> 20)
#define SRAM_SIZE 1 #define SRAM_SIZE 1
#define SRAM_END (SRAM_START + SRAM_SIZE) /* plus one... */ #define SRAM_END (SRAM_START + SRAM_SIZE) /* plus one... */
@ -43,7 +43,7 @@ void bootblock_cpu_init(void)
/* set up dcache and MMU */ /* set up dcache and MMU */
mmu_init(); mmu_init();
mmu_config_range(0, SRAM_START, DCACHE_OFF); mmu_disable_range(0, SRAM_START);
mmu_config_range(SRAM_START, SRAM_SIZE, DCACHE_WRITEBACK); mmu_config_range(SRAM_START, SRAM_SIZE, DCACHE_WRITEBACK);
mmu_config_range(SRAM_END, 4096 - SRAM_END, DCACHE_OFF); mmu_config_range(SRAM_END, 4096 - SRAM_END, DCACHE_OFF);
dcache_mmu_enable(); dcache_mmu_enable();

2
src/cpu/samsung/exynos5420/cpu.h
View File

@ -22,6 +22,8 @@
#include <arch/io.h> #include <arch/io.h>
#define EXYNOS5_SRAM_BASE 0x02020000
/* Base address registers */ /* Base address registers */
#define EXYNOS5420_GPIO_PART6_BASE 0x03860000 /* Z0 */ #define EXYNOS5420_GPIO_PART6_BASE 0x03860000 /* Z0 */
#define EXYNOS5_PRO_ID 0x10000000 #define EXYNOS5_PRO_ID 0x10000000