GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

src/console/Kconfig: Add option to disable loglevel prefix 

This patch adds an option to disable loglevel prefixes. This patch helps
to achieve clear messages when low loglevel is used and very few
messages are displayed on a terminal. This option also allows to
maintain compatibility with log readers and continuous integration
systems that depend on fixed log content.

If the code contains:
  printk(BIOS_DEBUG, "This is a debug message!\n")
it will show as:
  [DEBUG]  This is a debug message!
but if the Kconfig contains:
  CONFIG_CONSOLE_USE_LOGLEVEL_PREFIX=n
the same message will show up as
  This is a debug message!

Signed-off-by: Igor Bagnucki <igor.bagnucki@3mdeb.com>
Change-Id: I911bb601cf1933a4c6498b2ae1e4cb4d4bc85621
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63144
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
This commit is contained in:
Igor Bagnucki 2022-03-03 11:41:57 +01:00 committed by Felix Held
parent 773876401d
commit f0d65213c0
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/console/Kconfig
View File

@ -395,6 +395,15 @@ config DEFAULT_CONSOLE_LOGLEVEL
endif endif
config CONSOLE_USE_LOGLEVEL_PREFIX
bool "Use loglevel prefix to indicate line loglevel"
default y
help
When enabled, if the code contains a:
`printk(BIOS_DEBUG, "This is a debug message!\n")`,
it will show up as:
`[DEBUG] This is a debug message!`
config CONSOLE_USE_ANSI_ESCAPES config CONSOLE_USE_ANSI_ESCAPES
bool "Use ANSI escape sequences for console highlighting" bool "Use ANSI escape sequences for console highlighting"
default y default y

1
src/console/printk.c
View File

@ -96,6 +96,7 @@ static void line_start(union log_state state)
and potentially an escape sequence for highlighting. */ and potentially an escape sequence for highlighting. */
if (CONFIG(CONSOLE_USE_ANSI_ESCAPES)) if (CONFIG(CONSOLE_USE_ANSI_ESCAPES))
wrap_interactive_printf(BIOS_LOG_ESCAPE_PATTERN, bios_log_escape[state.level]); wrap_interactive_printf(BIOS_LOG_ESCAPE_PATTERN, bios_log_escape[state.level]);
if (CONFIG(CONSOLE_USE_LOGLEVEL_PREFIX))
wrap_interactive_printf(BIOS_LOG_PREFIX_PATTERN, bios_log_prefix[state.level]); wrap_interactive_printf(BIOS_LOG_PREFIX_PATTERN, bios_log_prefix[state.level]);
} }