mb/google/kahlee: Use GPIO_10 for EC_SYNC_IRQ

Use AGPIO 10 as the EC sync interrupt for MKBP events for sensor data.

On this platform, interrupts are routed via the GPIO controller so need to be
registered using GpioInt instead of Interrupt.

BUG=b:123750725
BRANCH=grunt
TEST=MKBP events still received (with matching EC and kernel changes)

Change-Id: If499d24511bbaa7054207b7e0b98445723332c4f
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://review.coreboot.org/c/31278
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Enrico Granata <egranata@chromium.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Edward Hill 2019-02-04 14:42:03 -07:00 committed by Patrick Georgi
parent 5349dd14d6
commit f14445c145
4 changed files with 22 additions and 2 deletions

View File

@ -32,6 +32,17 @@ Device (CREC)
})
#endif
#ifdef EC_ENABLE_SYNC_IRQ_GPIO
Name (_CRS, ResourceTemplate ()
{
GpioInt (Level, ActiveLow, Exclusive, PullDefault, 0x0000,
"\\_SB.GPIO", 0x00, ResourceConsumer, ,)
{
EC_SYNC_IRQ
}
})
#endif
#ifdef EC_ENABLE_MKBP_DEVICE
Device (CKSC)
{

View File

@ -15,3 +15,9 @@
/* Enable EC backed Keyboard Backlight in ACPI */
#define EC_ENABLE_KEYBOARD_BACKLIGHT
/*
* Enable EC sync interrupt via GPIO controller, EC_SYNC_IRQ is defined in
* variant/gpio.h
*/
#define EC_ENABLE_SYNC_IRQ_GPIO

View File

@ -14,3 +14,6 @@
*/
#include <baseboard/gpio.h>
/* EC sync irq is AGPIO 10 */
#define EC_SYNC_IRQ 10

View File

@ -117,8 +117,8 @@ static const struct soc_amd_gpio gpio_set_stage_ram[] = {
/* GPIO_8 - DDR_ALERT_3V3_L (currently not used) */
PAD_GPI(GPIO_8, PULL_UP),
/* GPIO_10 - SLP_S0_L (currently not used) */
PAD_NF(GPIO_10, S0A3_GPIO, PULL_UP),
/* GPIO_10 - SLP_S0_L, EC_SYNC_IRQ */
PAD_GPI(GPIO_10, PULL_UP),
/* GPIO_11 - TOUCHSCREEN_INT_3V3_ODL, SCI */
PAD_SCI(GPIO_11, PULL_UP, EDGE_LOW),